Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

ezusb: decouple some nodes from ezusb-iidx-emu - [merged] #230

New Issue
Closed
opened 2022-06-24 09:57:39 +03:00 by icex2 · 5 comments
icex2 commented 2022-06-24 09:57:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 24, 2022, 08:57

Merges build_fixes_iidx -> master

This fixes a build failure in newer gcc for popnhook.
Since node-16seg has a dependency on iidxio

Tested by building locally and making sure popnhook1 doesn't have iidxio references.

example image

Also tested and made sure iidxhookX-cn don't have references / links to eamio

In GitLab by @xyen on Jun 24, 2022, 08:57 _Merges build_fixes_iidx -> master_ This fixes a build failure in newer gcc for popnhook. Since node-16seg has a dependency on iidxio Tested by building locally and making sure popnhook1 doesn't have iidxio references. ![example image](https://bin.jvnv.net/file/kYcXR/image.png) Also tested and made sure iidxhookX-cn don't have references / links to eamio
icex2 commented 2022-06-24 10:58:10 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 24, 2022, 09:58

added 1 commit

  • 748b60e4 - iidxhook: split off node-16seg to remove eamio dependency from iidxhook-cn

Compare with previous version

In GitLab by @xyen on Jun 24, 2022, 09:58 added 1 commit <ul><li>748b60e4 - iidxhook: split off node-16seg to remove eamio dependency from iidxhook-cn</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/129/diffs?diff_id=2678&start_sha=3a4a23b272c4c6e378a37f41dc9c7a458556f3e3)
icex2 commented 2022-06-24 21:23:03 +03:00 (Migrated from github.com)
Copy Link
Copy Source

the cn versions should not have to rely on eamio as cards aren't even used.

the cn versions should not have to rely on eamio as cards aren't even used.
icex2 commented 2022-06-25 00:33:48 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 24, 2022, 23:33

Commented on src/main/iidxhook4-cn/Module.mk line 12

you may have reviewed an outdated version, this got fixed in a later commit

In GitLab by @xyen on Jun 24, 2022, 23:33 Commented on [src/main/iidxhook4-cn/Module.mk line 12](https://github.com/djhackersdev/bemanitools/compare/b360c86ab6d7bd20bf1405188fb41f50cf75e396..f0f6e22bcb630ad1f6e6a88e79aa9cbca4915a95#diff-ec06763730e06b38850db9f67b39f80bR12) you may have reviewed an outdated version, this got fixed in a later commit
icex2 commented 2022-06-25 00:34:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
icex2 commented 2022-06-25 00:34:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#230