Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

iidxhook5-cn: Fix log messages, Delete unnecessary code - [merged] #223

New Issue
Closed
opened 2022-06-12 19:53:27 +03:00 by icex2 · 7 comments
icex2 commented 2022-06-12 19:53:27 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @garbage on Jun 12, 2022, 18:53

Merges feature/cleanup-code-iidxhook5-cn -> master

In GitLab by @garbage on Jun 12, 2022, 18:53 _Merges feature/cleanup-code-iidxhook5-cn -> master_
icex2 commented 2022-06-13 23:50:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nice, thanks for cleaning up. The card reader would have actually been quite weird once someone else realized it's not being used.

Can you also remove eamio from iidxhook5-cn/Module.mk?

Nice, thanks for cleaning up. The card reader would have actually been quite weird once someone else realized it's not being used. Can you also remove `eamio` from `iidxhook5-cn/Module.mk`?
icex2 commented 2022-06-14 09:02:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @garbage on Jun 14, 2022, 08:02

added 1 commit

  • b6c1ff70 - iidxhook5-cn: delete unused libs in Module.mk

Compare with previous version

In GitLab by @garbage on Jun 14, 2022, 08:02 added 1 commit <ul><li>b6c1ff70 - iidxhook5-cn: delete unused libs in Module.mk</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/122/diffs?diff_id=2638&start_sha=497f1f5711e2d37731b722fcb1f9005231f02747)
icex2 commented 2022-06-14 09:07:04 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @garbage on Jun 14, 2022, 08:07

I did it.

I also removed acioemu.

In GitLab by @garbage on Jun 14, 2022, 08:07 I did it. I also removed `acioemu`.
icex2 commented 2022-06-16 00:28:17 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 7 commits

  • b6c1ff70...9f45efad - 4 commits from branch djhackers:master
  • 3a09b0dd - iidxhook5-cn: fix log
  • c68b77ca - iidxhook5-cn: delete unnecessary parts
  • b7c3c52a - iidxhook5-cn: delete unused libs in Module.mk

Compare with previous version

added 7 commits <ul><li>b6c1ff70...9f45efad - 4 commits from branch <code>djhackers:master</code></li><li>3a09b0dd - iidxhook5-cn: fix log</li><li>c68b77ca - iidxhook5-cn: delete unnecessary parts</li><li>b7c3c52a - iidxhook5-cn: delete unused libs in Module.mk</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/122/diffs?diff_id=2644&start_sha=b6c1ff703f649497cf6b8b7272787e503c17b208)
icex2 commented 2022-06-16 00:28:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks, looking great now.

Thanks, looking great now.
icex2 commented 2022-06-16 00:28:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
icex2 commented 2022-06-16 00:29:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#223