Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

update 'gamestart-02.bat' for ripples - [merged] #217

New Issue
Closed
opened 2022-05-23 10:17:00 +03:00 by icex2 · 5 comments
icex2 commented 2022-05-23 10:17:00 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @HAYU on May 23, 2022, 09:17

Merges master -> master

It's a very minor change, but it's necessary when who play the game for the first time. I guess jb-01 also will need to be same change, but it's impossible to check because i don't have data.

In GitLab by @HAYU on May 23, 2022, 09:17 _Merges master -> master_ It's a very minor change, but it's necessary when who play the game for the first time. I guess `jb-01` also will need to be same change, but it's impossible to check because i don't have data.
icex2 commented 2022-05-23 22:09:48 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Tiny but definintely a nice quality of life improvement which avoids confusion.

FYI: Your commit history is a bit messsed up, no idea what happened there. The total changeset is looking good though. I will just sqash them to a single commit on merge to clean these up.

Tiny but definintely a nice quality of life improvement which avoids confusion. FYI: Your commit history is a bit messsed up, no idea what happened there. The total changeset is looking good though. I will just sqash them to a single commit on merge to clean these up.
icex2 commented 2022-05-23 22:10:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
icex2 commented 2022-05-23 23:19:02 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @HAYU on May 23, 2022, 22:19

I'm sorry. I'm not used to git, so I don't know why the previous commit keeps popping up. Next time, I will make a request after solving it.

In GitLab by @HAYU on May 23, 2022, 22:19 I'm sorry. I'm not used to git, so I don't know why the previous commit keeps popping up. Next time, I will make a request after solving it.
icex2 commented 2022-05-26 02:11:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

No worries, I am happy if you take it as a learning and to improve on further contributions.

No worries, I am happy if you take it as a learning and to improve on further contributions.
icex2 commented 2022-05-26 02:11:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#217