fixes a crash when using sdvxhook2 on certain OS versions (windows 7 on cabs in particular), and set title pop lights to 50% by default in sdvxio-bio2.
In GitLab by @xyen on May 20, 2022, 05:54
_Merges sdvx-fixes -> master_
fixes a crash when using sdvxhook2 on certain OS versions (windows 7 on cabs in particular), and set title pop lights to 50% by default in sdvxio-bio2.
You are checking if the pointer value is > UIN16_MAX?
Would expect you want to check the dereferenced value, i.e. *((intptr_t) name) > UINT16_MAX
If your code is correct, do you mind explaining why (and maybe add that explanation to the commit message or code as a comment?
You are checking if the pointer value is > UIN16_MAX?
Would expect you want to check the dereferenced value, i.e. `*((intptr_t) name) > UINT16_MAX`
If your code is correct, do you mind explaining why (and maybe add that explanation to the commit message or code as a comment?
In GitLab by @xyen on May 28, 2022, 01:22
Commented on [src/main/sdvxhook2/nvapi.c line 36](https://github.com/djhackersdev/bemanitools/compare/188a14e4ea80d510062715a6cf2624471cd44986..ccfe6f7923bd94552d23a1384ec194c3aa444d0e#diff-aa1413986bc58c795ab84bc75df25cbeR36)
It's explained right below in the Microsoft doc.
In GitLab by @xyen on May 28, 2022, 01:26
added 3 commits
<ul><li>188a14e4 - 1 commit from branch <code>master</code></li><li>bf805e39 - sdvxio-bio2: set title pop lights to 50% by default</li><li>ccfe6f79 - sdvxhook2: fix crash when using sdvxhook2 on certain OS versions</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/115/diffs?diff_id=2540&start_sha=d3cf76568c13e41cfea2b4e6db9e3c2ddd8a459b)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @xyen on May 20, 2022, 05:54
Merges sdvx-fixes -> master
fixes a crash when using sdvxhook2 on certain OS versions (windows 7 on cabs in particular), and set title pop lights to 50% by default in sdvxio-bio2.
You are checking if the pointer value is > UIN16_MAX?
Would expect you want to check the dereferenced value, i.e.
*((intptr_t) name) > UINT16_MAXIf your code is correct, do you mind explaining why (and maybe add that explanation to the commit message or code as a comment?
In GitLab by @xyen on May 28, 2022, 01:22
Commented on src/main/sdvxhook2/nvapi.c line 36
It's explained right below in the Microsoft doc.
resolved all threads
-_-" for not having the full view and seeing the next few lines. lgtm
approved this merge request
In GitLab by @xyen on May 28, 2022, 01:26
added 3 commits
188a14e4- 1 commit from branchmasterbf805e39- sdvxio-bio2: set title pop lights to 50% by defaultccfe6f79- sdvxhook2: fix crash when using sdvxhook2 on certain OS versionsCompare with previous version