Add sdvx generator lights to sdvxio-bio2. - [merged] #215

Closed
opened 2022-05-19 07:32:44 +03:00 by icex2 · 3 comments
icex2 commented 2022-05-19 07:32:44 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on May 19, 2022, 06:32

Merges master -> master

Added the generator lights for sdvxio-bio2. Red and Green are PWM analog, while Blue is GPIO digital. This behavior and mapping was confirmed by studying the behavior on an original sdvx 1-4 pcb.

Built with docker & tested on an sdvx bio2 pcb with sdvx 4.

In GitLab by @cam_prevail on May 19, 2022, 06:32 _Merges master -> master_ Added the generator lights for sdvxio-bio2. Red and Green are PWM analog, while Blue is GPIO digital. This behavior and mapping was confirmed by studying the behavior on an original sdvx 1-4 pcb. Built with docker & tested on an sdvx bio2 pcb with sdvx 4.
icex2 commented 2022-05-19 07:34:00 +03:00 (Migrated from github.com)

In GitLab by @cam_prevail on May 19, 2022, 06:34

added 1 commit

  • 64f1fa4b - Fix formatting in sdvxio.h

Compare with previous version

In GitLab by @cam_prevail on May 19, 2022, 06:34 added 1 commit <ul><li>64f1fa4b - Fix formatting in sdvxio.h</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/114/diffs?diff_id=2484&start_sha=0d00395bcb4b869b5587800c5ab0651f6020c112)
icex2 commented 2022-05-20 06:49:23 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 20, 2022, 05:49

Looks good to me, though we should expose these through config/geninput as well (as icex2 noted to me offline), I don't think generator lights are worth invalidating old configs / forcing a config version update.

In GitLab by @xyen on May 20, 2022, 05:49 Looks good to me, though we should expose these through config/geninput as well (as icex2 noted to me offline), I don't think generator lights are worth invalidating old configs / forcing a config version update.
icex2 commented 2022-05-20 06:49:28 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 20, 2022, 05:49

approved this merge request

In GitLab by @xyen on May 20, 2022, 05:49 approved this merge request
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#215