When a blank hardid is provided in the avs2-ea3 configuration, launcher will synthesize one based on the MAC address retrieved via AVS. Unfortunately, this structure expanded in 2.16 and again in 2.17.
Description
Add the additional avs_net_interface fields so AVS does not return an error in ea3_ident_hardid_from_ethernet.
Related Issue
How Has This Been Tested?
I tested this locally with beatmania IIDX 26: Rootage when I was trying to see if 100% usage on a single CPU core was tools related.
Checklist
Implemented (unit) test(s) which prove that the introduced changes are working as expected.
Tested with the following games:
beatmania IIDX 26: Rootage
Followed the developer (style) guidelines.
Updated existing doc of or add new doc to README file(s).
Updated development documentation.
There were no existing unit tests against AVS functions so I did not add one.
In GitLab by @Felix on Oct 26, 2021, 01:25
_Merges avs-net -> master_
## Summary
When a blank `hardid` is provided in the `avs2-ea3` configuration, `launcher` will synthesize one based on the MAC address retrieved via AVS. Unfortunately, this structure expanded in 2.16 and again in 2.17.
## Description
Add the additional `avs_net_interface` fields so AVS does not return an error in `ea3_ident_hardid_from_ethernet`.
## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->
## How Has This Been Tested?
I tested this locally with beatmania IIDX 26: Rootage when I was trying to see if 100% usage on a single CPU core was tools related.
## Checklist
<!-- Make sure you covered all items, which apply, of the checklist below. -->
<!-- Strikethrough items that do not apply and provide a brief description why. -->
* ~~Implemented (unit) test(s) which prove that the introduced changes are working as expected.~~
* Tested with the following games:
* [x] beatmania IIDX 26: Rootage
* [x] Followed the developer (style) guidelines.
* ~~Updated existing doc of or add new doc to README file(s).~~
* ~~Updated development documentation.~~
There were no existing unit tests against AVS functions so I did not add one.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @Felix on Oct 26, 2021, 01:25
Merges avs-net -> master
Summary
When a blank
hardidis provided in theavs2-ea3configuration,launcherwill synthesize one based on the MAC address retrieved via AVS. Unfortunately, this structure expanded in 2.16 and again in 2.17.Description
Add the additional
avs_net_interfacefields so AVS does not return an error inea3_ident_hardid_from_ethernet.Related Issue
How Has This Been Tested?
I tested this locally with beatmania IIDX 26: Rootage when I was trying to see if 100% usage on a single CPU core was tools related.
Checklist
Implemented (unit) test(s) which prove that the introduced changes are working as expected.Updated existing doc of or add new doc to README file(s).Updated development documentation.There were no existing unit tests against AVS functions so I did not add one.
In GitLab by @xyen on Oct 26, 2021, 01:34
approved this merge request
In GitLab by @xyen on Oct 26, 2021, 01:44
great catch, lgtm!