Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

acio: adds definitions for RVOL and MDXF - [merged] #205

New Issue
Closed
opened 2021-09-13 05:50:24 +03:00 by icex2 · 9 comments
icex2 commented 2021-09-13 05:50:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 04:50

Merges acio_ddr -> master

Also adds aciodrv / aciotest for RVOL, MDXF is not included as someone else is working on a driver for it already.

In GitLab by @xyen on Sep 13, 2021, 04:50 _Merges acio_ddr -> master_ Also adds aciodrv / aciotest for RVOL, MDXF is not included as someone else is working on a driver for it already.
icex2 commented 2021-09-13 05:51:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 04:51

added 11 commits

  • e7af2a7a...78c7d959 - 4 commits from branch master
  • 8f46a08e - ddrhook: move common hooks to ddrhook-util
  • 5e5daffc - acio: add MDXF node definition
  • 0fdd51cd - acioemu: update name of AC_IO_ICCA_CMD_DEVICE_CONTROL
  • e6042ade - aciodrv: add method to get product type of node
  • 14b75817 - acio: add RVOL node definition
  • 346f1d66 - aciotest: add RVOL test, and change to use product types instead of names
  • 76eca30e - bio2: add definitions for 20th anniversary model

Compare with previous version

In GitLab by @xyen on Sep 13, 2021, 04:51 added 11 commits <ul><li>e7af2a7a...78c7d959 - 4 commits from branch <code>master</code></li><li>8f46a08e - ddrhook: move common hooks to ddrhook-util</li><li>5e5daffc - acio: add MDXF node definition</li><li>0fdd51cd - acioemu: update name of AC_IO_ICCA_CMD_DEVICE_CONTROL</li><li>e6042ade - aciodrv: add method to get product type of node</li><li>14b75817 - acio: add RVOL node definition</li><li>346f1d66 - aciotest: add RVOL test, and change to use product types instead of names</li><li>76eca30e - bio2: add definitions for 20th anniversary model</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/104/diffs?diff_id=1885&start_sha=e7af2a7a53a4a1e78ae5a3903be8cd7824d5708b)
icex2 commented 2021-09-13 23:19:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I am not sure here, but afaik this gets filled up automatically to a full byte. However, I would suggest to fill this up with a uint8_t padding : 4 or uint8_t unused : 4

I am not sure here, but afaik this gets filled up automatically to a full byte. However, I would suggest to fill this up with a `uint8_t padding : 4` or `uint8_t unused : 4`
icex2 commented 2021-09-13 23:20:48 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Why 0 and not 0xFFFFFFFF? If both are fine, I would use the latter as it is more noticable in debug output/logs.

Why `0` and not `0xFFFFFFFF`? If both are fine, I would use the latter as it is more noticable in debug output/logs.
icex2 commented 2021-09-13 23:26:07 +03:00 (Migrated from github.com)
Copy Link
Copy Source
    log_assert(device);
    log_assert(pout);

pin optional and null check below.

```suggestion:-0+0 log_assert(device); log_assert(pout); ``` pin optional and null check below.
icex2 commented 2021-09-13 23:26:54 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Just some minor stuff, everything else lgtm. Feel free to merge when addressed and nothing else to clarify.

Just some minor stuff, everything else lgtm. Feel free to merge when addressed and nothing else to clarify.
icex2 commented 2021-09-13 23:35:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 22:35

Commented on src/main/acio/mdxf.h line 19

This is in a union, which is why I left it unpadded (the union itself is what provides the raw access if you need the other bits).

In GitLab by @xyen on Sep 13, 2021, 22:35 Commented on [src/main/acio/mdxf.h line 19](https://github.com/djhackersdev/bemanitools/compare/78c7d959e69c4bd8d7b71332aa2026506b58d3eb..d05207bdb2d5e54eb278b746c66e1f0fa50a4d72#diff-def91d72e6f050aa7898ea7166224a34R19) This is in a union, which is why I left it unpadded (the union itself is what provides the raw access if you need the other bits).
icex2 commented 2021-09-13 23:35:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 22:35

Commented on src/main/aciodrv/device.c line 399

0 isn't a valid node as far as I know, since product_type is a uint32_t, I don't think -1 makes sense here.

In GitLab by @xyen on Sep 13, 2021, 22:35 Commented on [src/main/aciodrv/device.c line 399](https://github.com/djhackersdev/bemanitools/compare/78c7d959e69c4bd8d7b71332aa2026506b58d3eb..d05207bdb2d5e54eb278b746c66e1f0fa50a4d72#diff-1c1a2ad8deb60fa4bb473a3e4f9e4732R399) 0 isn't a valid node as far as I know, since product_type is a uint32_t, I don't think -1 makes sense here.
icex2 commented 2021-09-13 23:38:48 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 22:38

added 1 commit

Compare with previous version

In GitLab by @xyen on Sep 13, 2021, 22:38 added 1 commit <ul><li>d05207bd - acio: minor fixes</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/104/diffs?diff_id=1887&start_sha=76eca30e7a84e85aac1f0b8879a038142fe504eb)
icex2 commented 2021-09-13 23:39:07 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 13, 2021, 22:39

resolved all threads

In GitLab by @xyen on Sep 13, 2021, 22:39 resolved all threads
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#205