Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

jbio-p4io impl and updated jbio API to fully support test menu - [merged] #191

New Issue
Closed
opened 2021-04-04 10:28:58 +03:00 by icex2 · 58 comments
icex2 commented 2021-04-04 10:28:58 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 4, 2021, 09:28

Merges feature/jbio-p4io -> master

Summary

This is the required pre-work to get p3io games working on p4io cabs, but it's a big feature on its own so it's been put into its own MR.

Description

Missing functionality had to be implemented in a breaking change to jbio - this was deemed OK due to the lack of pre-existing jbio hooks.
Features are

  • Support individual corners via jb_io_set_panel_mode
  • Support coin blocker due to it affecting corner testing

In addition, jbio-p4io was added to open a p4io device + H44B over ACIO for input and lights.

Related Issue

!55 depends on this for full cab support.

How Has This Been Tested?

This is fairly standalone and only changes to jubeat hooks were made. Tested that PC based jubeat still works as normal, and my p4io cab based jubeat can work with the new jbio-p4io. Also tested using jbiotest.exe. Using festo.

Checklist

Documentation has been added.
I've tried to stick to generally-good style, but because make code-format makes a huge amount of changes to the rest of the codebase, I can't run it. I've discussed this with Xyen and after this (and !55) are merged, a new MR with code-format run can be merged to simplify your life here.

In GitLab by @mon on Apr 4, 2021, 09:28 _Merges feature/jbio-p4io -> master_ ## Summary This is the required pre-work to get p3io games working on p4io cabs, but it's a big feature on its own so it's been put into its own MR. ## Description Missing functionality had to be implemented in a breaking change to jbio - this was deemed OK due to the lack of pre-existing jbio hooks. Features are - Support individual corners via jb_io_set_panel_mode - Support coin blocker due to it affecting corner testing In addition, jbio-p4io was added to open a p4io device + H44B over ACIO for input and lights. ## Related Issue !55 depends on this for full cab support. ## How Has This Been Tested? This is fairly standalone and only changes to jubeat hooks were made. Tested that PC based jubeat still works as normal, and my p4io cab based jubeat can work with the new jbio-p4io. Also tested using jbiotest.exe. Using festo. ## Checklist Documentation has been added. I've tried to stick to generally-good style, but because `make code-format` makes a huge amount of changes to the rest of the codebase, I can't run it. I've discussed this with Xyen and after this (and !55) are merged, a new MR with code-format run can be merged to simplify your life here.
icex2 commented 2021-04-04 11:35:38 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 4, 2021, 10:35

added 1 commit

Compare with previous version

In GitLab by @mon on Apr 4, 2021, 10:35 added 1 commit <ul><li>9d27936e - remove spurious warning</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1562&start_sha=19d7175bd3ab72873ae22728c961fa7f196139a4)
icex2 commented 2021-04-05 13:37:46 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Makes me wonder, do we have some easy to use bat scripts for that like we have for iidx? If not, might be worth adding them for the different versions and provide commands for the most common use case.

Makes me wonder, do we have some easy to use bat scripts for that like we have for iidx? If not, might be worth adding them for the different versions and provide commands for the most common use case.
icex2 commented 2021-04-05 13:39:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* You can change the port and baudrate of the H44B node by editing the `jbio-h44b.conf` that should be created by default

I don't see a default jbio-h44b.conf in the changeset. Can you add one to the dist files and include it in the dist packages in Module.mk?

```suggestion:-0+0 * You can change the port and baudrate of the H44B node by editing the `jbio-h44b.conf` that should be created by default ``` I don't see a default `jbio-h44b.conf` in the changeset. Can you add one to the `dist` files and include it in the dist packages in `Module.mk`?
icex2 commented 2021-04-05 13:42:05 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I assume this is "empty" because it runs together with the "main IO" on the same bus? Since I would have expect some kind of init code here, could you add a brief comment explaining why you don't have to initialize anything here?

I assume this is "empty" because it runs together with the "main IO" on the same bus? Since I would have expect some kind of init code here, could you add a brief comment explaining why you don't have to initialize anything here?
icex2 commented 2021-04-05 13:42:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Add log_assert(lights)

Nit: Add `log_assert(lights)`
icex2 commented 2021-04-05 13:49:15 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I just crossed checked this with the icca module and it seems like this was missing previously...I assume that means iccb didn't work at all?

I just crossed checked this with the `icca` module and it seems like this was missing previously...I assume that means iccb didn't work at all?
icex2 commented 2021-04-05 13:52:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Ah, I think that was causing some issues with "unresponsive inputs" back when I looked into jb support for a bit. Nice seeing this implemented properly now 👍

Ah, I think that was causing some issues with "unresponsive inputs" back when I looked into jb support for a bit. Nice seeing this implemented properly now :thumbsup:
icex2 commented 2021-04-05 13:53:51 +03:00 (Migrated from github.com)
Copy Link
Copy Source

The magicbox IO doesn't support this and always returns a merged state per panel?

The magicbox IO doesn't support this and always returns a merged state per panel?
icex2 commented 2021-04-05 13:55:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Missing cleanup, e.g. aciomgr_port_fini?

Missing cleanup, e.g. `aciomgr_port_fini`?
icex2 commented 2021-04-05 14:00:12 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Well, that might be the case, but I personally would not rely on that even if we just copy-pasted the API for now. It will bloat the code, yes, but makes it less error prone to any changes there.

Well, that might be the case, but I personally would not rely on that even if we just copy-pasted the API for now. It will bloat the code, yes, but makes it less error prone to any changes there.
icex2 commented 2021-04-05 14:02:08 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Naming nit:

    uint8_t header_aa;
Naming nit: ```suggestion:-0+0 uint8_t header_aa; ```
icex2 commented 2021-04-05 14:02:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Suggestion: Have these in enum which is self documenting?

Suggestion: Have these in enum which is self documenting?
icex2 commented 2021-04-05 14:04:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Very good and important comment 👍

Very good and important comment :thumbsup:
icex2 commented 2021-04-05 14:05:16 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Why? Would that lead to any issues? In general, I would favor to always check errors if this is not causing incompatibility issues due to relying on "broken code".

Why? Would that lead to any issues? In general, I would favor to always check errors if this is not causing incompatibility issues due to relying on "broken code".
icex2 commented 2021-04-05 14:06:20 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I really like the separation of concerns here with a low-level usb foo handling module. Makes the code easier to read and understand. Well done.

I really like the separation of concerns here with a low-level usb foo handling module. Makes the code easier to read and understand. Well done.
icex2 commented 2021-04-05 14:07:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Move 0xAA into a macro or constant.

Nit: Move 0xAA into a macro or constant.
icex2 commented 2021-04-05 14:08:36 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I don't understand that part and it looks super hacky changing the requested amount of bytes. Can you provide some more information on why this is required and what would be the result if you would not do that?

I don't understand that part and it looks super hacky changing the requested amount of bytes. Can you provide some more information on why this is required and what would be the result if you would not do that?
icex2 commented 2021-04-05 14:11:00 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: To be very nitty about that interface, I don't think the USB layer knows about something like "jamma" at this point. Considering you also use a very generic p4io_usb_transfer which fits nicely, I would suggest to align the naming here (is it an interrupt endpoint?).

Nit: To be very nitty about that interface, I don't think the USB layer knows about something like "jamma" at this point. Considering you also use a very generic `p4io_usb_transfer` which fits nicely, I would suggest to align the naming here (is it an interrupt endpoint?).
icex2 commented 2021-04-05 14:11:50 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Ah, now these header files make sense: Sharing them between emulation and real device code. Nice 👍

Ah, now these header files make sense: Sharing them between emulation and real device code. Nice :thumbsup:
icex2 commented 2021-04-05 14:12:59 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Not your change, but magic numbers suck when you have to figure out what they mean years later. Do you happen to know why we need the 8 here and the 32 on P4IO_CMD_DALLAS_READ_MEM?

Not your change, but magic numbers suck when you have to figure out what they mean years later. Do you happen to know why we need the `8` here and the `32` on `P4IO_CMD_DALLAS_READ_MEM`?
icex2 commented 2021-04-06 13:00:10 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:00

Commented on doc/jbhook/jbio-p4io.md line 15

I based this off sdvx-hwio which does not include these configuration files - they are created on first run. Should I still add them?

In GitLab by @mon on Apr 6, 2021, 12:00 Commented on [doc/jbhook/jbio-p4io.md line 15](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..6955c0e526a5a76bd0dc0c11c44c20cf3344a36a#diff-12df2b86720d9ac4774f67cdd592621aR15) I based this off sdvx-hwio which does not include these configuration files - they are created on first run. Should I still add them?
icex2 commented 2021-04-06 13:02:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:02

Commented on src/main/acioemu/iccb.c line 172

It worked fine! The geninput based ic card module has an eam_io_poll that does nothing. Forgetting to call it only affects eamio impls that actually need to be polled, and nobody has ever done that with jubeat before.

In GitLab by @mon on Apr 6, 2021, 12:02 Commented on [src/main/acioemu/iccb.c line 172](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-f8e805172aa1619225cd291ba3385e33R172) It worked fine! The geninput based ic card module has an eam_io_poll that does nothing. Forgetting to call it only affects eamio impls that actually need to be polled, and nobody has ever done that with jubeat before.
icex2 commented 2021-04-06 13:03:23 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:03

Commented on src/main/jbhook/io.c line 145

Actually, the unresponsive inputs were caused by a backwards-bitmask - all panels were constantly pressed, and pressing the key un-pressed the input. The unresponsive input was caused by inputs coming from key release, not key press!

In GitLab by @mon on Apr 6, 2021, 12:03 Commented on [src/main/jbhook/io.c line 145](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-453e3514f48290ebe57167c073a3aa84R145) Actually, the unresponsive inputs were caused by a backwards-bitmask - all panels were constantly pressed, and pressing the key un-pressed the input. The unresponsive input was caused by inputs coming from key release, not key press!
icex2 commented 2021-04-06 13:05:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:05

Commented on src/main/p4io/cmd.h line 26

Oh! I removed this because the type name ends with header and the member in struct p4io_cmd_package is also header, so I thought the header in the name could be removed. Could you explain your reasoning?

I can change the upper to lowercase, of course.

In GitLab by @mon on Apr 6, 2021, 12:05 Commented on [src/main/p4io/cmd.h line 26](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..a3e248ea939f86bbed000737b45d70c081969bfd#diff-33feaff2e51f0368ea4e65e1aa3e651fR26) Oh! I removed this because the type name ends with `header` and the member in `struct p4io_cmd_package` is also `header`, so I thought the header in the name could be removed. Could you explain your reasoning? I can change the upper to lowercase, of course.
icex2 commented 2021-04-06 13:07:16 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:07

Commented on src/main/p4iodrv/device.c line 90

The main reason is because the reset command returns a 0 byte response - not even an "OK" status, 0 bytes in total. That technically should be returning an error, but because reset is a special case it ignores it. If you're happy with that explanation feel free to resolve.

In GitLab by @mon on Apr 6, 2021, 12:07 Commented on [src/main/p4iodrv/device.c line 90](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..afb32be31acf1abcc15eadc26bd9c01eecf1280a#diff-26669bc4aabc952cd156c75059dff4abR90) The main reason is because the reset command returns a 0 byte response - not even an "OK" status, 0 bytes in total. That technically should be returning an error, but because reset is a special case it ignores it. If you're happy with that explanation feel free to resolve.
icex2 commented 2021-04-06 13:08:29 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:08

Commented on src/main/p4ioemu/device.c line 136

I have no idea, I suspect it's just matched to the number of bytes realio happens to return for that request...

In GitLab by @mon on Apr 6, 2021, 12:08 Commented on [src/main/p4ioemu/device.c line 136](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-5a294e51859cd55ee292d969a322ec08L136) I have no idea, I suspect it's just matched to the number of bytes realio happens to return for that request...
icex2 commented 2021-04-06 13:12:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:12

Commented on src/main/jbio-magicbox/jbio.c line 146

I don't know if it can support single panel mode, and I don't care to find out - the test menu certainly doesn't expose anything of the sort. I'll add a comment in my documentation commit.

In GitLab by @mon on Apr 6, 2021, 12:12 Commented on [src/main/jbio-magicbox/jbio.c line 146](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-75f0d9d67a5e659e5eef446d7710f095R146) I don't know if it *can* support single panel mode, and I don't care to find out - the test menu certainly doesn't expose anything of the sort. I'll add a comment in my documentation commit.
icex2 commented 2021-04-06 13:15:14 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:15

Commented on src/main/p4iodrv/usb.c line 139

This comment was updated in a later commit to read:
// must be 65 bytes or requests can stall - only 64 will ever be returned
Acceptable detail, or needs more?

In GitLab by @mon on Apr 6, 2021, 12:15 Commented on [src/main/p4iodrv/usb.c line 139](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..59f4bd79e4f074865a2915da10cf0c4dc60d04e9#diff-557360177156e5c7037b209511174db0R139) This comment was updated in a later commit to read: `// must be 65 bytes or requests can stall - only 64 will ever be returned` Acceptable detail, or needs more?
icex2 commented 2021-04-06 13:17:14 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I think we started including them because people were not reading the readme files and wondering where the configuration files are. Therefore, I suggest we stick to what we have been doing for the hooks so far. As for the sdvx-hwio one, that should be added as well (can be done in a follow-up MR).

I think we started including them because people were not reading the readme files and wondering where the configuration files are. Therefore, I suggest we stick to what we have been doing for the hooks so far. As for the sdvx-hwio one, that should be added as well (can be done in a follow-up MR).
icex2 commented 2021-04-06 13:18:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Fair point with the "header in header" part. Then just lowercase is fine.

Fair point with the "header in header" part. Then just lowercase is fine.
icex2 commented 2021-04-06 13:19:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:19

added 1 commit

  • a3e248ea - H44B drv: add missed deinit code, comments

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:19 added 1 commit <ul><li>a3e248ea - H44B drv: add missed deinit code, comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1568&start_sha=9d27936eb0bb3e791eac66eb3d550dfed29a9850)
icex2 commented 2021-04-06 13:20:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Yes, I am. Could you add this detail "because the reset command returns a 0 byte response - not even an "OK" status, 0 bytes in total. That technically should be returning an error, but because reset is a special case it ignores it." to the comment? I think this is quite essential for anyone picking this up to understand the actual reasoning behind that.

Yes, I am. Could you add this detail "because the reset command returns a 0 byte response - not even an "OK" status, 0 bytes in total. That technically should be returning an error, but because reset is a special case it ignores it." to the comment? I think this is quite essential for anyone picking this up to understand the actual reasoning behind that.
icex2 commented 2021-04-06 13:20:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:20

Commented on src/main/aciodrv/h44b.c line 18

Added doc in a3e248ea

In GitLab by @mon on Apr 6, 2021, 12:20 Commented on [src/main/aciodrv/h44b.c line 18](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-c0f547de0b6678d122561590822af692R18) Added doc in a3e248ea
icex2 commented 2021-04-06 13:20:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:20

Commented on src/main/aciodrv/h44b.c line 28

Added in a3e248ea

In GitLab by @mon on Apr 6, 2021, 12:20 Commented on [src/main/aciodrv/h44b.c line 28](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-c0f547de0b6678d122561590822af692R28) Added in a3e248ea
icex2 commented 2021-04-06 13:20:54 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nope, I think the new comment makes this part clear. Forgot to remove this comment after seeing it on one of the newer commits.

Nope, I think the new comment makes this part clear. Forgot to remove this comment after seeing it on one of the newer commits.
icex2 commented 2021-04-06 13:23:12 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:23

Commented on src/main/p4io/cmd.h line 26

changed this line in version 4 of the diff

In GitLab by @mon on Apr 6, 2021, 12:23 Commented on [src/main/p4io/cmd.h line 26](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..a3e248ea939f86bbed000737b45d70c081969bfd#diff-33feaff2e51f0368ea4e65e1aa3e651fR26) changed this line in [version 4 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1570&start_sha=a3e248ea939f86bbed000737b45d70c081969bfd#30c32b720a07af2a0f7b8299cb407980f683512f_26_28)
icex2 commented 2021-04-06 13:23:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:23

Commented on src/main/p4iodrv/usb.c line 121

changed this line in version 4 of the diff

In GitLab by @mon on Apr 6, 2021, 12:23 Commented on [src/main/p4iodrv/usb.c line 121](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..a3e248ea939f86bbed000737b45d70c081969bfd#diff-557360177156e5c7037b209511174db0R121) changed this line in [version 4 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1570&start_sha=a3e248ea939f86bbed000737b45d70c081969bfd#55a1892b70fc5721e52d26b335d79de754a62c1e_121_121)
icex2 commented 2021-04-06 13:23:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:23

added 1 commit

  • 45d67ab1 - p4io: change magic AA to P4IO_SOF

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:23 added 1 commit <ul><li>45d67ab1 - p4io: change magic AA to P4IO_SOF</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1570&start_sha=a3e248ea939f86bbed000737b45d70c081969bfd)
icex2 commented 2021-04-06 13:23:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:23

Commented on src/main/p4io/cmd.h line 26

I changed my mind with the other review comment about 0xAA being a magic number - with a P4IO_SOF #define I've changed this member to be sof. Solves all issues! Commit 45d67ab1

In GitLab by @mon on Apr 6, 2021, 12:23 Commented on [src/main/p4io/cmd.h line 26](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..a3e248ea939f86bbed000737b45d70c081969bfd#diff-33feaff2e51f0368ea4e65e1aa3e651fR26) I changed my mind with the other review comment about 0xAA being a magic number - with a `P4IO_SOF` #define I've changed this member to be `sof`. Solves all issues! Commit 45d67ab1
icex2 commented 2021-04-06 13:25:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:25

added 1 commit

  • 525c17f9 - jbio-magicbox: comment nonfunctional jb_io_set_panel_mode

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:25 added 1 commit <ul><li>525c17f9 - jbio-magicbox: comment nonfunctional jb_io_set_panel_mode</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1572&start_sha=45d67ab141a200e8955492e46b0bbb3ebe16ec2b)
icex2 commented 2021-04-06 13:25:49 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:25

Commented on src/main/jbio-magicbox/jbio.c line 146

Sorted in 525c17f9

In GitLab by @mon on Apr 6, 2021, 12:25 Commented on [src/main/jbio-magicbox/jbio.c line 146](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-75f0d9d67a5e659e5eef446d7710f095R146) Sorted in 525c17f9
icex2 commented 2021-04-06 13:26:20 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:26

Commented on src/main/jbio-p4io/h44b.c line 81

Fixed in a3e248ea, good catch

In GitLab by @mon on Apr 6, 2021, 12:26 Commented on [src/main/jbio-p4io/h44b.c line 81](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-6c4412d5fb4999aa76a00f465925fb40R81) Fixed in a3e248ea, good catch
icex2 commented 2021-04-06 13:28:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:28

Commented on src/main/p4iodrv/usb.h line 10

changed this line in version 6 of the diff

In GitLab by @mon on Apr 6, 2021, 12:28 Commented on [src/main/p4iodrv/usb.h line 10](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..525c17f9f1a77ec16ef2335382e0df0fdb5ba1c3#diff-058e3ec44f4d9e118ce19919722896a7R10) changed this line in [version 6 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1574&start_sha=525c17f9f1a77ec16ef2335382e0df0fdb5ba1c3#1dabdbff62da39eee60c2d929b928108a53ffc8a_10_10)
icex2 commented 2021-04-06 13:28:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:28

added 1 commit

  • afb32be3 - p4io/usb: clarify jamma reads use interrupt handle

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:28 added 1 commit <ul><li>afb32be3 - p4io/usb: clarify jamma reads use interrupt handle</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1574&start_sha=525c17f9f1a77ec16ef2335382e0df0fdb5ba1c3)
icex2 commented 2021-04-06 13:30:58 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:30

Commented on src/main/p4iodrv/device.c line 90

changed this line in version 7 of the diff

In GitLab by @mon on Apr 6, 2021, 12:30 Commented on [src/main/p4iodrv/device.c line 90](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..afb32be31acf1abcc15eadc26bd9c01eecf1280a#diff-26669bc4aabc952cd156c75059dff4abR90) changed this line in [version 7 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1576&start_sha=afb32be31acf1abcc15eadc26bd9c01eecf1280a#e4d00a8e4cba003682980313e1ba932f0241b58d_90_90)
icex2 commented 2021-04-06 13:30:59 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:30

added 1 commit

  • 4222c6a1 - Clarify p4io_cmd_init's lack of response checking

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:30 added 1 commit <ul><li>4222c6a1 - Clarify p4io_cmd_init&#39;s lack of response checking</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1576&start_sha=afb32be31acf1abcc15eadc26bd9c01eecf1280a)
icex2 commented 2021-04-06 13:35:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:35

Commented on src/main/p4io/cmd.h line 40

changed this line in version 8 of the diff

In GitLab by @mon on Apr 6, 2021, 12:35 Commented on [src/main/p4io/cmd.h line 40](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..4222c6a1ebeb3d46574e77b716536e62b58e48f8#diff-33feaff2e51f0368ea4e65e1aa3e651fR40) changed this line in [version 8 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1578&start_sha=4222c6a1ebeb3d46574e77b716536e62b58e48f8#30c32b720a07af2a0f7b8299cb407980f683512f_40_45)
icex2 commented 2021-04-06 13:35:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:35

added 1 commit

  • d06d2c75 - Add enum p4io_roundplug_type for clarity

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:35 added 1 commit <ul><li>d06d2c75 - Add enum p4io_roundplug_type for clarity</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1578&start_sha=4222c6a1ebeb3d46574e77b716536e62b58e48f8)
icex2 commented 2021-04-06 13:52:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:52

Commented on src/main/jbio-p4io/jbio.c line 193

changed this line in version 9 of the diff

In GitLab by @mon on Apr 6, 2021, 12:52 Commented on [src/main/jbio-p4io/jbio.c line 193](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..d06d2c753df9d7eaf7450a25af7b920c18acf6d3#diff-081adcc02002e7c07581014b8b54baebR193) changed this line in [version 9 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1580&start_sha=d06d2c753df9d7eaf7450a25af7b920c18acf6d3#a60a2ddb6ebfcd3c9d9134159b2e1a1c93d5f392_193_193)
icex2 commented 2021-04-06 13:52:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:52

added 1 commit

  • 6955c0e5 - Make h44b light mapping explicit

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:52 added 1 commit <ul><li>6955c0e5 - Make h44b light mapping explicit</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1580&start_sha=d06d2c753df9d7eaf7450a25af7b920c18acf6d3)
icex2 commented 2021-04-06 13:54:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:54

Commented on doc/jbhook/jbio-p4io.md line 15

changed this line in version 10 of the diff

In GitLab by @mon on Apr 6, 2021, 12:54 Commented on [doc/jbhook/jbio-p4io.md line 15](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..6955c0e526a5a76bd0dc0c11c44c20cf3344a36a#diff-12df2b86720d9ac4774f67cdd592621aR15) changed this line in [version 10 of the diff](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1582&start_sha=6955c0e526a5a76bd0dc0c11c44c20cf3344a36a#38239a0de176d792c6d0f8daf5b35afaf017190e_15_15)
icex2 commented 2021-04-06 13:54:23 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:54

added 1 commit

  • aa22b282 - Add missing backticks in jbio-p4io.md

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:54 added 1 commit <ul><li>aa22b282 - Add missing backticks in jbio-p4io.md</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1582&start_sha=6955c0e526a5a76bd0dc0c11c44c20cf3344a36a)
icex2 commented 2021-04-06 13:59:00 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:59

added 1 commit

  • 3c4b73ee - Add default jbio-h44b.conf to /dist

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 12:59 added 1 commit <ul><li>3c4b73ee - Add default jbio-h44b.conf to /dist</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1584&start_sha=aa22b2829ba70434c9fd52119dd3b5ef1eab5d20)
icex2 commented 2021-04-06 13:59:14 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 12:59

Commented on doc/jbhook/jbio-p4io.md line 15

Added in 3c4b73ee

In GitLab by @mon on Apr 6, 2021, 12:59 Commented on [doc/jbhook/jbio-p4io.md line 15](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..6955c0e526a5a76bd0dc0c11c44c20cf3344a36a#diff-12df2b86720d9ac4774f67cdd592621aR15) Added in 3c4b73ee
icex2 commented 2021-04-06 14:04:46 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 13:04

added 1 commit

  • f42579bc - Clarify how eamio-icca works with jbio-p4io

Compare with previous version

In GitLab by @mon on Apr 6, 2021, 13:04 added 1 commit <ul><li>f42579bc - Clarify how eamio-icca works with jbio-p4io</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/90/diffs?diff_id=1586&start_sha=3c4b73ee1100e83066711255394ba547430b10d6)
icex2 commented 2021-04-06 14:05:49 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Apr 6, 2021, 13:05

Commented on doc/jbhook/jbio-p4io.md line 11

Added some documentation about using eamio in f42579bc - with the DLLs renamed, the stock gamestart.bat works fine and is in fact what I am using on my cab right now. I don't think separate .bat files are needed as with IIDX.

In GitLab by @mon on Apr 6, 2021, 13:05 Commented on [doc/jbhook/jbio-p4io.md line 11](https://github.com/djhackersdev/bemanitools/compare/33e65d5446d75482f19501bdf68b17ce896a6050..f42579bc669de3f048ff543622dd061bcb6adbd3#diff-12df2b86720d9ac4774f67cdd592621aR11) Added some documentation about using eamio in f42579bc - with the DLLs renamed, the stock `gamestart.bat` works fine and is in fact what I am using on my cab right now. I don't think separate .bat files are needed as with IIDX.
icex2 commented 2021-04-06 14:09:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
icex2 commented 2021-04-06 14:09:36 +03:00 (Migrated from github.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#191