D3d9ex force screen res - [merged] #170

Closed
opened 2020-12-19 19:01:24 +03:00 by icex2 · 7 comments
icex2 commented 2020-12-19 19:01:24 +03:00 (Migrated from github.com)

Merges d3d9ex-force-screen-res -> master

Summary

Add an option to the d3d9ex module and iidxhook9 to force a specific screen resolution.

Description

Copy-paste from readme:

The graphics backend of the game is auto detecting the resolution and refresh
rate based on the supported specs reported by the monitor. Depending on that
output, this can lead to the game picking some "odd" resolution like 1386x768
even the game is set to HD mode (expecting 1280x720).

Furthermore, this can lead to different refresh rate values on the automatic
monitor check, e.g. compared to previous versions (59.94 on Rootage but 60.02
on Heroic Verse). Ultimately, the result can be a very offsync gameplay
experience with extremely delayed input.

Related Issue

How Has This Been Tested?

IIDX 27 with a screen that makes the game go to 1368x768 instead of 1280x720 when HD mode is set in the operator menu.

Checklist

  • Tested with the following games:
    • IIDX 27
  • Followed the developer (style) guidelines.
  • Updated existing doc of or add new doc to README file(s).
_Merges d3d9ex-force-screen-res -> master_ ## Summary <!--- Provide a general summary of your changes in the Title above --> Add an option to the d3d9ex module and iidxhook9 to force a specific screen resolution. ## Description <!--- Describe your changes in detail --> Copy-paste from readme: The graphics backend of the game is auto detecting the resolution and refresh rate based on the supported specs reported by the monitor. Depending on that output, this can lead to the game picking some "odd" resolution like 1386x768 even the game is set to HD mode (expecting 1280x720). Furthermore, this can lead to different refresh rate values on the automatic monitor check, e.g. compared to previous versions (59.94 on Rootage but 60.02 on Heroic Verse). Ultimately, the result can be a very offsync gameplay experience with extremely delayed input. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> IIDX 27 with a screen that makes the game go to 1368x768 instead of 1280x720 when HD mode is set in the operator menu. ## Checklist <!-- Make sure you covered all items, which apply, of the checklist below. --> <!-- Strikethrough items that do not apply and provide a brief description why. --> * Tested with the following games: * [x] IIDX 27 * [x] Followed the developer (style) guidelines. * [x] Updated existing doc of or add new doc to README file(s).
icex2 commented 2020-12-20 01:03:57 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 19, 2020, 23:03

Commented on src/main/d3d9exhook/d3d9ex.c line 304

%dx%x -> %dx%d should be %dx%d -> %dx%d

In GitLab by @xyen on Dec 19, 2020, 23:03 Commented on [src/main/d3d9exhook/d3d9ex.c line 304](https://github.com/djhackersdev/bemanitools/compare/5b174ca07f778320b05b32facb2bb9b1c24a332c..773dcc06f0520510dd3a416a97564a6a9674eb3f#diff-88be4261cef25befc4653e41ac224407R304) `%dx%x -> %dx%d` should be `%dx%d -> %dx%d`
icex2 commented 2020-12-20 01:03:57 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 19, 2020, 23:03

Commented on src/main/d3d9exhook/d3d9ex.c line 303

nit: Maybe add a case logging if only 1 of these are set?

In GitLab by @xyen on Dec 19, 2020, 23:03 Commented on [src/main/d3d9exhook/d3d9ex.c line 303](https://github.com/djhackersdev/bemanitools/compare/5b174ca07f778320b05b32facb2bb9b1c24a332c..3199a4fa4eda09a4eea62d5dd42673990a0f532d#diff-88be4261cef25befc4653e41ac224407R303) nit: Maybe add a case logging if only 1 of these are set?
icex2 commented 2020-12-20 01:04:03 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 19, 2020, 23:04

approved this merge request

In GitLab by @xyen on Dec 19, 2020, 23:04 approved this merge request
icex2 commented 2020-12-20 01:04:16 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 19, 2020, 23:04

Approving aside from the 2 minor corrections above.

In GitLab by @xyen on Dec 19, 2020, 23:04 Approving aside from the 2 minor corrections above.
icex2 commented 2020-12-20 01:19:23 +03:00 (Migrated from github.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/69/diffs?diff_id=1393&start_sha=773dcc06f0520510dd3a416a97564a6a9674eb3f#635ef12b21ec4a077c76251b15c5580dd5d42f19_304_304)
icex2 commented 2020-12-20 01:19:24 +03:00 (Migrated from github.com)

added 3 commits

  • f4e81146 - d3d9ex: Add force screen resolution feature
  • ac49dcf5 - dist/iidx: Update dist config file with new parameters force screen res
  • 3199a4fa - doc/iidxhook9: Add doc to FAQ how and when to use force screen res

Compare with previous version

added 3 commits <ul><li>f4e81146 - d3d9ex: Add force screen resolution feature</li><li>ac49dcf5 - dist/iidx: Update dist config file with new parameters force screen res</li><li>3199a4fa - doc/iidxhook9: Add doc to FAQ how and when to use force screen res</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/69/diffs?diff_id=1393&start_sha=773dcc06f0520510dd3a416a97564a6a9674eb3f)
icex2 commented 2020-12-20 01:19:31 +03:00 (Migrated from github.com)

resolved all threads

resolved all threads
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#170