Tested on my own cabinet with an original Konami BIO2 from a IIDX 25 PCB + sub IO to hook it up to the C02 wiring of the cabinet.
Checklist
Tested with the following games:
iidx 27
Followed the developer (style) guidelines.
Updated existing doc of or add new doc to README file(s).
Updated development documentation.
_Merges iidxio-bio2 -> master_
## Summary
<!--- Provide a general summary of your changes in the Title above -->
Implements the iidxio API using the iidxio bio2 driver. This allows you to play any game that supports BT5's iidxio API.
## Description
<!--- Describe your changes in detail -->
Not a lot to add, summary covers that.
## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->
* https://dev.s-ul.eu/djhackers/bemanitools/-/issues/8
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->
Tested on my own cabinet with an original Konami BIO2 from a IIDX 25 PCB + sub IO to hook it up to the C02 wiring of the cabinet.
## Checklist
<!-- Make sure you covered all items, which apply, of the checklist below. -->
<!-- Strikethrough items that do not apply and provide a brief description why. -->
* Tested with the following games:
* [x] iidx 27
* [x] Followed the developer (style) guidelines.
* [x] Updated existing doc of or add new doc to README file(s).
* [x] Updated development documentation.
A comment here describing what happens if we use the wrong value would be nice.
In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on [src/main/bio2drv/bi2a-iidx.c line 15](https://github.com/djhackersdev/bemanitools/compare/3199a4fa4eda09a4eea62d5dd42673990a0f532d..e49b1e05c1116855e5ec326b976226150b70e6b8#diff-84c63f8bc3347c0c5d39083f095891a9R15)
A comment here describing what happens if we use the wrong value would be nice.
(which is the crucial part for automatic detection). -> (which is the crucial part for the stock game's automatic detection).
In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on [doc/iidxhook/iidxhook9.md line 111](https://github.com/djhackersdev/bemanitools/compare/9a5dc503f4161888f40256565bcc573359e7498e..121a9d0c3d0c63527d06328be7c3cfef2f9c0238#diff-fea5743bfe4ee6faf404023fe8938f02R111)
`(which is the crucial part for automatic detection).` -> `(which is the crucial part for the stock game's automatic detection).`
In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on [src/main/bio2emu-iidx/bi2a.c line 88](https://github.com/djhackersdev/bemanitools/compare/9a5dc503f4161888f40256565bcc573359e7498e..121a9d0c3d0c63527d06328be7c3cfef2f9c0238#diff-059e4fc6a4af5cff30ed74e1d8070407R88)
CLEAR -> `BIO2_BI2A_CMD_INIT`
nit: better yet move both this one and the one in bi2a-sdvx to the header.
In GitLab by @xyen on Dec 19, 2020, 23:22
Commented on [src/main/bio2drv/bi2a-iidx.c line 15](https://github.com/djhackersdev/bemanitools/compare/3199a4fa4eda09a4eea62d5dd42673990a0f532d..e49b1e05c1116855e5ec326b976226150b70e6b8#diff-84c63f8bc3347c0c5d39083f095891a9R15)
nit: better yet move both this one and the one in bi2a-sdvx to the header.
I wouldn't move that to the header since, at least with current knowledge, this is an implementation detail specific to that usage of the IO, e.g. sdvx vs. iidx.
Added clarifying comment because that's a good point.
I wouldn't move that to the header since, at least with current knowledge, this is an implementation detail specific to that usage of the IO, e.g. sdvx vs. iidx.
Added clarifying comment because that's a good point.
changed this line in [version 10 of the diff](/djhackers/bemanitools/-/merge_requests/66/diffs?diff_id=1394&start_sha=121a9d0c3d0c63527d06328be7c3cfef2f9c0238#2e95b22b67daac5afa9f41dc85e884de49a151e5_111_111)
changed this line in [version 10 of the diff](/djhackers/bemanitools/-/merge_requests/66/diffs?diff_id=1394&start_sha=121a9d0c3d0c63527d06328be7c3cfef2f9c0238#37a78211cd4ba0f2a032c680b0f78ff769e1d4d9_88_88)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Merges iidxio-bio2 -> master
Summary
Implements the iidxio API using the iidxio bio2 driver. This allows you to play any game that supports BT5's iidxio API.
Description
Not a lot to add, summary covers that.
Related Issue
How Has This Been Tested?
Tested on my own cabinet with an original Konami BIO2 from a IIDX 25 PCB + sub IO to hook it up to the C02 wiring of the cabinet.
Checklist
added 3 commits
Compare with previous version
added 4 commits
Compare with previous version
marked this merge request as draft from bf90b20c049d7d9fc614fc761fcd1ec1fca3ed70
added 1 commit
Compare with previous version
added 7 commits
Compare with previous version
added 2 commits
Compare with previous version
added 1 commit
Compare with previous version
marked the checklist item Updated existing doc of or add new doc to README file(s). as completed
marked the checklist item Updated development documentation. as completed
added 14 commits
Compare with previous version
marked this merge request as ready
Updated, moved ViGEm relevant commits to its own MR !68
added 16 commits
Compare with previous version
In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on src/main/bio2drv/bi2a-iidx.c line 15
A comment here describing what happens if we use the wrong value would be nice.
In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on doc/iidxhook/iidxhook9.md line 111
(which is the crucial part for automatic detection).->(which is the crucial part for the stock game's automatic detection).In GitLab by @xyen on Dec 19, 2020, 23:19
Commented on src/main/bio2emu-iidx/bi2a.c line 88
CLEAR ->
BIO2_BI2A_CMD_INITIn GitLab by @xyen on Dec 19, 2020, 23:22
Commented on src/main/bio2drv/bi2a-iidx.c line 15
nit: better yet move both this one and the one in bi2a-sdvx to the header.
In GitLab by @xyen on Dec 19, 2020, 23:22
approving aside from some minor changes
In GitLab by @xyen on Dec 19, 2020, 23:22
approved this merge request
I wouldn't move that to the header since, at least with current knowledge, this is an implementation detail specific to that usage of the IO, e.g. sdvx vs. iidx.
Added clarifying comment because that's a good point.
changed this line in version 10 of the diff
changed this line in version 10 of the diff
added 7 commits
Compare with previous version
resolved all threads
added 26 commits
masterc7a84fbd- bio2: Update unknown commands8bfa8917- bio2/iidx: Swap in and out struct names to align with sdvx definitions15911177- Add missing iidx 27 avs version info to list69614a30- Module.mk: Apply lex sort to includesba3a1ce2- doc/api: Add missing sdvxio implementations to liste7ed8e21- bt5 api/iidxio: Add missing enum to easily identify top lamp orderb4cd23d5- iidxiotool: Fix incorrect top lamp order for setting outputb7fe7232- bio2/iidx: Deduplicate node command, use common acio base commandb832ad74- bio2/iidx: Add enums to easily map top lamps and panel buttons287b3705- bio2drv: Add implementation for iidx7740e5e0- iidxio-bio2: Add iidxio implementation using bio2 iidx driverf0bd33bc- dev doc: Documented BIO2 package dumps used for debuggingf42c5ace- bio2: Add BIO2_BI2A_CMD_INIT command63064d34- bi2a: Clarify data field usage on init commandf41c9995- bi2a-iidx: Fix incorrect init command dataec5102f5- hardware doc: ezusb RJ45 to DIN8 connector pinout30d346a3- doc: Add iidxio-bio2 documentation7d0cb64a- doc: Improve visibility of iidxio API implementations10e085c1- doc/iidxhook9: Add notes about BIO2 driver usagee49b1e05- doc/hardware: Add information about bio2 turntable bypass cableCompare with previous version