This has been confirmed to work on a real MagicBox cab, and uses zyp's graciously provided source.
This also adds the --kill-at flag to the dlltool invocation, as otherwise stdcall imports have their @ suffixes included. No other imports currently use stdcall.
In GitLab by @mon on Oct 4, 2020, 08:29
_Merges jbio-magicbox -> master_
This has been confirmed to work on a real MagicBox cab, and uses zyp's graciously provided source.
This also adds the `--kill-at` flag to the `dlltool` invocation, as otherwise stdcall imports have their @ suffixes included. No other imports currently use stdcall.
Nit: Specify that the renamed dll needs to be located in the same directory as the jbhook.dll which should be located next to jubeat.dll or however the main executable/lib is called.
Nit: Specify that the renamed dll needs to be located in the same directory as the `jbhook.dll` which should be located next to `jubeat.dll` or however the main executable/lib is called.
Seeing that this is provided by an external lib, I didn't see any reference in the jbio-magixbox.md readme about this being required. Is that correct? Furthermore, do you mind adding a few comments about what this lib is about and where it is included?
Seeing that this is provided by an external lib, I didn't see any reference in the `jbio-magixbox.md` readme about this being required. Is that correct? Furthermore, do you mind adding a few comments about what this lib is about and where it is included?
Please avoid inline structure/union definitions as they make reading the actual flow rather difficult. Not necessarily here but I have seen people creating a hell of a function when doing this everywhere. I suggest moving this to the top of the file and naming it magicbox_input
Please avoid inline structure/union definitions as they make reading the actual flow rather difficult. Not necessarily here but I have seen people creating a hell of a function when doing this everywhere. I suggest moving this to the top of the file and naming it `magicbox_input`
I copied this from sdvx-bio2.md, so that might be worth fixing as well!
In GitLab by @mon on Oct 5, 2020, 05:50
Commented on [doc/jbhook/jbio-magicbox.md line 5](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..c8a2aaeaa117833a68afba8e8676fbec8eb5191b#diff-c241f33b7d2eeb06096e9819c9fd13c0R5)
I copied this from sdvx-bio2.md, so that might be worth fixing as well!
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on [src/main/jbio-magicbox/jbio.c line 15](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..c8a2aaeaa117833a68afba8e8676fbec8eb5191b#diff-75f0d9d67a5e659e5eef446d7710f095R15)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1327&start_sha=c8a2aaeaa117833a68afba8e8676fbec8eb5191b#517795816af8a1b2925e5fff295269f96345d03e_15_15)
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on [doc/jbhook/jbio-magicbox.md line 6](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..c8a2aaeaa117833a68afba8e8676fbec8eb5191b#diff-c241f33b7d2eeb06096e9819c9fd13c0R6)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1327&start_sha=c8a2aaeaa117833a68afba8e8676fbec8eb5191b#215f4146e70f7c0010685438d8dc097782817b4d_6_5)
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on [doc/jbhook/jbio-magicbox.md line 5](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..c8a2aaeaa117833a68afba8e8676fbec8eb5191b#diff-c241f33b7d2eeb06096e9819c9fd13c0R5)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1327&start_sha=c8a2aaeaa117833a68afba8e8676fbec8eb5191b#215f4146e70f7c0010685438d8dc097782817b4d_5_5)
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on [src/main/jbio-magicbox/jbio.c line 81](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..c8a2aaeaa117833a68afba8e8676fbec8eb5191b#diff-75f0d9d67a5e659e5eef446d7710f095R81)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1327&start_sha=c8a2aaeaa117833a68afba8e8676fbec8eb5191b#517795816af8a1b2925e5fff295269f96345d03e_81_85)
In GitLab by @mon on Oct 5, 2020, 05:56
added 1 commit
<ul><li>70a34f6d - Cleanup</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1327&start_sha=c8a2aaeaa117833a68afba8e8676fbec8eb5191b)
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on [src/imports/ch341.h line 14](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..7908fd703d7f9b22315f5dafbb9494a1121b9092#diff-db50973e605ce4af5e4f4c95a954f49eR14)
Done!
I added them to the jbio-magicbox.md, do you want an extra comment here?
In GitLab by @mon on Oct 6, 2020, 01:53
Commented on [src/imports/ch341.h line 14](https://github.com/djhackersdev/bemanitools/compare/46b1ddbc1a6a93a05a90b55bba5a23fbe38e3b80..7908fd703d7f9b22315f5dafbb9494a1121b9092#diff-db50973e605ce4af5e4f4c95a954f49eR14)
I added them to the `jbio-magicbox.md`, do you want an extra comment here?
That part is totally find for the readme to set things up. However, I thought more about providing a few brief high level comments regarding what this library is actually doing. Just something like "This library is used by magic box to interface with their propriatary IO hardware. The hardware supports <insert here type of inputs/buttons and count supported> inputs and outputs."
I know this can be derived from the code, but I think this is valuable to have. It helps getting the idea of "what is this thing about" just quicker.
That part is totally find for the readme to set things up. However, I thought more about providing a few brief high level comments regarding what this library is actually doing. Just something like "This library is used by magic box to interface with their propriatary IO hardware. The hardware supports <insert here type of inputs/buttons and count supported> inputs and <insert list of types of outputs and counts> outputs."
I know this can be derived from the code, but I think this is valuable to have. It helps getting the idea of "what is this thing about" just quicker.
In GitLab by @mon on Oct 10, 2020, 14:07
added 1 commit
<ul><li>7908fd70 - Better comments in ch341.h</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/54/diffs?diff_id=1332&start_sha=70a34f6df01b422876f0a7f5e91720872c4eeb2a)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @mon on Oct 4, 2020, 08:29
Merges jbio-magicbox -> master
This has been confirmed to work on a real MagicBox cab, and uses zyp's graciously provided source.
This also adds the
--kill-atflag to thedlltoolinvocation, as otherwise stdcall imports have their @ suffixes included. No other imports currently use stdcall.Nit: Specify that the renamed dll needs to be located in the same directory as the
jbhook.dllwhich should be located next tojubeat.dllor however the main executable/lib is called.Also, add the single back quotes for filenames, e.g.
jbio-magicbox.dllandjbio.dllSeeing that this is provided by an external lib, I didn't see any reference in the
jbio-magixbox.mdreadme about this being required. Is that correct? Furthermore, do you mind adding a few comments about what this lib is about and where it is included?Nit: Can be made
staticPlease avoid inline structure/union definitions as they make reading the actual flow rather difficult. Not necessarily here but I have seen people creating a hell of a function when doing this everywhere. I suggest moving this to the top of the file and naming it
magicbox_inputUnclear variable name. Number of players?
In GitLab by @mon on Oct 5, 2020, 05:50
Commented on doc/jbhook/jbio-magicbox.md line 5
I copied this from sdvx-bio2.md, so that might be worth fixing as well!
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on src/main/jbio-magicbox/jbio.c line 15
changed this line in version 2 of the diff
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on doc/jbhook/jbio-magicbox.md line 6
changed this line in version 2 of the diff
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on doc/jbhook/jbio-magicbox.md line 5
changed this line in version 2 of the diff
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on src/main/jbio-magicbox/jbio.c line 81
changed this line in version 2 of the diff
In GitLab by @mon on Oct 5, 2020, 05:56
added 1 commit
Compare with previous version
In GitLab by @mon on Oct 5, 2020, 05:56
Commented on src/imports/ch341.h line 14
Done!
In GitLab by @mon on Oct 5, 2020, 05:56
resolved all threads
I don't see this being included in the MR. Did you forget to push your changes?
In GitLab by @mon on Oct 6, 2020, 01:53
Commented on src/imports/ch341.h line 14
I added them to the
jbio-magicbox.md, do you want an extra comment here?That part is totally find for the readme to set things up. However, I thought more about providing a few brief high level comments regarding what this library is actually doing. Just something like "This library is used by magic box to interface with their propriatary IO hardware. The hardware supports <insert here type of inputs/buttons and count supported> inputs and outputs."
I know this can be derived from the code, but I think this is valuable to have. It helps getting the idea of "what is this thing about" just quicker.
In GitLab by @mon on Oct 10, 2020, 14:07
added 1 commit
Compare with previous version
In GitLab by @mon on Oct 10, 2020, 14:07
How's this?
In GitLab by @mon on Oct 10, 2020, 14:07
resolved all threads
That's good now, thanks for iterating.
approved this merge request
resolved all threads
Helped out and rebased that for you @mon. See here for merge: https://dev.s-ul.eu/djhackers/bemanitools/-/merge_requests/62