Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

vigem-sdvxio - [merged] #153

New Issue
Closed
opened 2020-09-14 06:09:28 +03:00 by icex2 · 52 comments
icex2 commented 2020-09-14 06:09:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 05:09

Merges vigem -> master

Allows acrealio/cab owners to use KFCA/BIO2 devices as xbox controllers with the use of a ViGEm client.

In GitLab by @xyen on Sep 14, 2020, 05:09 _Merges vigem -> master_ Allows acrealio/cab owners to use KFCA/BIO2 devices as xbox controllers with the use of a ViGEm client.
icex2 commented 2020-09-14 06:16:51 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 05:16

added 1 commit

Compare with previous version

In GitLab by @xyen on Sep 14, 2020, 05:16 added 1 commit <ul><li>3bda5001 - vigem-sdvxio: Add readme</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1315&start_sha=926bd38970176c4c4f3a2cb094682804c4324598)
icex2 commented 2020-09-14 21:39:05 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I don't think that's a good "user interface". I suggest exposing a value of 0.0 (min) to 1.0 (max) which increases volume the greater the number is. This maps to the decimal 96-0 accordingly in the implementation.

I don't think that's a good "user interface". I suggest exposing a value of 0.0 (min) to 1.0 (max) which increases volume the greater the number is. This maps to the decimal 96-0 accordingly in the implementation.
icex2 commented 2020-09-14 21:41:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: I wouldn't expect the exit call to be inside the config-vigem-sdvxio. Instead, I suggest let the function return a boolean value if reading the config was successful or not and exit on false.

Nit: I wouldn't expect the `exit` call to be inside the `config-vigem-sdvxio`. Instead, I suggest let the function return a boolean value if reading the config was successful or not and exit on false.
icex2 commented 2020-09-14 22:10:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: I suggest prefixing any errors going to stdout with "ERROR: ..."

Nit: I suggest prefixing any errors going to stdout with "ERROR: ..."
icex2 commented 2020-09-14 22:11:08 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Just saw that you are using the logger in main.c. Why not use it here instead of printf?

Just saw that you are using the logger in `main.c`. Why not use it here instead of `printf`?
icex2 commented 2020-09-14 22:12:15 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Empty line after this and before if-block.

Nit: Empty line after this and before if-block.
icex2 commented 2020-09-14 22:12:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Empty line after this and before if-block.

Nit: Empty line after this and before if-block.
icex2 commented 2020-09-14 22:12:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Empty line after this and before while-block.

Nit: Empty line after this and before while-block.
icex2 commented 2020-09-14 22:16:11 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I would not bind this to controller specific buttons. These could be used somewhere else, e.g. I would use them in a game loader to quit the current game. Instead, I suggest check for CTRL+C for exiting the loop.

I would not bind this to controller specific buttons. These could be used somewhere else, e.g. I would use them in a game loader to quit the current game. Instead, I suggest check for CTRL+C for exiting the loop.
icex2 commented 2020-09-14 22:16:54 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Is this call still sending data to the hardware? I expected another sdvx_io_write_output after this call.

Is this call still sending data to the hardware? I expected another `sdvx_io_write_output` after this call.
icex2 commented 2020-09-14 22:17:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Related to the above, I would add some log output before the loop to tell the user how to exit the loop/program.

Related to the above, I would add some log output before the loop to tell the user how to exit the loop/program.
icex2 commented 2020-09-14 22:19:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Maybe easier to understand: "This application allows you to use any sdvxio backend, e.g. sdvxio-kfca.dll, to be available as a XBOX 360 game controller on windows."

Maybe easier to understand: "This application allows you to use any sdvxio backend, e.g. `sdvxio-kfca.dll`, to be available as a XBOX 360 game controller on windows."
icex2 commented 2020-09-14 22:20:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Install [ViGEmBus](https://github.com/ViGEm/ViGEmBus/releases)
```suggestion:-0+0 * Install [ViGEmBus](https://github.com/ViGEm/ViGEmBus/releases) ```
icex2 commented 2020-09-14 22:20:51 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Place the following in the same folder as `vigem-sdvxio.exe`:
```suggestion:-0+0 * Place the following in the same folder as `vigem-sdvxio.exe`: ```
icex2 commented 2020-09-14 22:21:08 +03:00 (Migrated from github.com)
Copy Link
Copy Source
  * Get a copy of [ViGEmClient.dll](https://bin.jvnv.net/file/ZgMJK/ViGEmClient.zip)
```suggestion:-0+0 * Get a copy of [ViGEmClient.dll](https://bin.jvnv.net/file/ZgMJK/ViGEmClient.zip) ```
icex2 commented 2020-09-14 22:21:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Also, that zip or it's contents should rather go to bemanitools-supplements than assuming the link will be alive forever.

Also, that zip or it's contents should rather go to `bemanitools-supplements` than assuming the link will be alive forever.
icex2 commented 2020-09-14 22:22:15 +03:00 (Migrated from github.com)
Copy Link
Copy Source
  * Rename your corresponding `sdvxio-XXX.dll`, e.g. `sdvxio-kfca.dll`, to `sdvxio.dll`.
```suggestion:-0+0 * Rename your corresponding `sdvxio-XXX.dll`, e.g. `sdvxio-kfca.dll`, to `sdvxio.dll`. ```
icex2 commented 2020-09-14 22:22:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Run `vigem-sdvxio.exe` so that the config file gets created
```suggestion:-0+0 * Run `vigem-sdvxio.exe` so that the config file gets created ```
icex2 commented 2020-09-14 22:22:53 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Edit `vigem-sdvxio.conf` so that the config file gets created as needed
```suggestion:-0+0 * Edit `vigem-sdvxio.conf` so that the config file gets created as needed ```
icex2 commented 2020-09-14 22:23:01 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Run `vigem-sdvxio.exe`
```suggestion:-0+0 * Run `vigem-sdvxio.exe` ```
icex2 commented 2020-09-14 22:23:46 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I suggest linking to the instructions in markdown.

I suggest linking to the instructions in markdown.
icex2 commented 2020-09-14 22:24:05 +03:00 (Migrated from github.com)
Copy Link
Copy Source
* Make sure to `ewfmgr C: -commit` and reboot after installing the drivers (this only needs to be done once)
```suggestion:-0+0 * Make sure to `ewfmgr C: -commit` and reboot after installing the drivers (this only needs to be done once) ```
icex2 commented 2020-09-14 22:24:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

I assume this applies to real cabinets running the embedded Windows, only? If so, please add this as a note.

I assume this applies to real cabinets running the embedded Windows, only? If so, please add this as a note.
icex2 commented 2020-09-14 22:34:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 21:34

Commented on src/main/vigemstub/helper.c line 14

didn't want to introduce a logger dependency, but I guess that makes more sense.

In GitLab by @xyen on Sep 14, 2020, 21:34 Commented on [src/main/vigemstub/helper.c line 14](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-6aa3fcd901441393af80aaf9dcc363b9R14) didn't want to introduce a logger dependency, but I guess that makes more sense.
icex2 commented 2020-09-14 22:34:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 21:34

Commented on src/main/vigem-sdvxio/main.c line 246

Most people won't have a keyboard attached to their cab, I will add a message saying that TEST+SERVICE will quit the IO program though (although not many people will probably use this feature, it's more for debugging).

In GitLab by @xyen on Sep 14, 2020, 21:34 Commented on [src/main/vigem-sdvxio/main.c line 246](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..8055ab868f9efb2c0b057a61f71e888b825a0ef7#diff-abb8bac123e295143e252f2920ee8654R246) Most people won't have a keyboard attached to their cab, I will add a message saying that TEST+SERVICE will quit the IO program though (although not many people will probably use this feature, it's more for debugging).
icex2 commented 2020-09-14 22:34:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 21:34

Commented on doc/sdvxhook/vigem-sdvxio.md line 7

Will upload to bt-supplements after this is merged, will update to mention that it'll be in there though.

In GitLab by @xyen on Sep 14, 2020, 21:34 Commented on [doc/sdvxhook/vigem-sdvxio.md line 7](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R7) Will upload to bt-supplements after this is merged, will update to mention that it'll be in there though.
icex2 commented 2020-09-14 22:34:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 14, 2020, 21:34

Commented on src/main/vigem-sdvxio/main.c line 258

Yes, sdvx_io_set_amp_volume calls its own ACIO command, sdvx_io_write_output doesn't actually call any ACIO command, it's sdvx_io_read_input that does, since the polling command does both input and output.

In GitLab by @xyen on Sep 14, 2020, 21:34 Commented on [src/main/vigem-sdvxio/main.c line 258](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..8055ab868f9efb2c0b057a61f71e888b825a0ef7#diff-abb8bac123e295143e252f2920ee8654R258) Yes, `sdvx_io_set_amp_volume` calls its own ACIO command, `sdvx_io_write_output` doesn't actually call any ACIO command, it's `sdvx_io_read_input` that does, since the polling command does both input and output.
icex2 commented 2020-09-14 22:37:50 +03:00 (Migrated from github.com)
Copy Link
Copy Source

That makes me wonder, how are they running more than one application, e.g. sdvx and some emulator.

That makes me wonder, how are they running more than one application, e.g. sdvx and some emulator.
icex2 commented 2020-09-14 22:39:20 +03:00 (Migrated from github.com)
Copy Link
Copy Source

This is rather out of scope here, but I think that is not a good way for how the implementation of the API is supposed the work. The API doc doesn't state that and based on the API of iidxio, I would assume this just being a simple setter, setting some backend buffers. Any read and write calls should do the heavy lifting and push data to the hardware or pull from it.

This is rather out of scope here, but I think that is not a good way for how the implementation of the API is supposed the work. The API doc doesn't state that and based on the API of `iidxio`, I would assume this just being a simple setter, setting some backend buffers. Any `read` and `write` calls should do the heavy lifting and push data to the hardware or pull from it.
icex2 commented 2020-09-15 20:02:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 15, 2020, 19:02

Commented on src/main/vigem-sdvxio/main.c line 258

iidxio works like that because that's how the hw IO works. The read/write calls perform specific commands that happen to be those. For ACIO devices the polling read and write are the same function, and there's additional read/writes. Queuing messages and waiting to send them on read_input/write_output would lead to a bad time TM.

In GitLab by @xyen on Sep 15, 2020, 19:02 Commented on [src/main/vigem-sdvxio/main.c line 258](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..8055ab868f9efb2c0b057a61f71e888b825a0ef7#diff-abb8bac123e295143e252f2920ee8654R258) iidxio works like that because that's how the hw IO works. The read/write calls perform specific commands that happen to be those. For ACIO devices the polling read and write are the same function, and there's additional read/writes. Queuing messages and waiting to send them on read_input/write_output would lead to a bad time TM.
icex2 commented 2020-09-15 20:02:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 15, 2020, 19:02

Commented on src/main/vigem-sdvxio/main.c line 246

You can connect a keyboard for initial setup, and then edit the boot flow if you want to keep using something other then the main game.

In GitLab by @xyen on Sep 15, 2020, 19:02 Commented on [src/main/vigem-sdvxio/main.c line 246](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..8055ab868f9efb2c0b057a61f71e888b825a0ef7#diff-abb8bac123e295143e252f2920ee8654R246) You can connect a keyboard for initial setup, and then edit the boot flow if you want to keep using something other then the main game.
icex2 commented 2020-09-15 20:02:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 15, 2020, 19:02

Commented on src/main/vigem-sdvxio/config-vigem-sdvxio.c line 50

Was speaking to some test users 0-1.0 is less user friendly. Especially since the scaling isn't linear.

In GitLab by @xyen on Sep 15, 2020, 19:02 Commented on [src/main/vigem-sdvxio/config-vigem-sdvxio.c line 50](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..8055ab868f9efb2c0b057a61f71e888b825a0ef7#diff-f9e872f20f75d0d9626bb248bd3b2597R50) Was speaking to some test users 0-1.0 is less user friendly. Especially since the scaling isn't linear.
icex2 commented 2020-09-15 20:06:44 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Oh, that's unexpected. Then I guess it's fine keeping it as already implemented.

Oh, that's unexpected. Then I guess it's fine keeping it as already implemented.
icex2 commented 2020-09-15 20:08:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Still not convinced but I also don't have any personal use-cases to backup my request. Therefore, it's ok to keep it as implemented.

Still not convinced but I also don't have any personal use-cases to backup my request. Therefore, it's ok to keep it as implemented.
icex2 commented 2020-09-15 20:10:09 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks for explanation. Makes sense to keep it that way to reflect the underlying hardware and avoid architectural complexity and issues. 👍

Thanks for explanation. Makes sense to keep it that way to reflect the underlying hardware and avoid architectural complexity and issues. :+1:
icex2 commented 2020-09-27 04:46:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on src/main/vigemstub/helper.c line 14

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [src/main/vigemstub/helper.c line 14](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-6aa3fcd901441393af80aaf9dcc363b9R14) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#65523cc6df4f2b1fecc69d2cf3ebabc3bf8548da_14_15)
icex2 commented 2020-09-27 04:46:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on src/main/vigem-sdvxio/config-vigem-sdvxio.c line 114

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [src/main/vigem-sdvxio/config-vigem-sdvxio.c line 114](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-f9e872f20f75d0d9626bb248bd3b2597R114) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#89221450de7f7253228e11bb6539bbde5e697bae_114_134)
icex2 commented 2020-09-27 04:46:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 1

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 1](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R1) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_1_1)
icex2 commented 2020-09-27 04:46:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 5

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 5](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R5) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_5_5)
icex2 commented 2020-09-27 04:46:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 7

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 7](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R7) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_7_7)
icex2 commented 2020-09-27 04:46:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 8

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 8](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R8) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_8_7)
icex2 commented 2020-09-27 04:46:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 9

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 9](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R9) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_9_7)
icex2 commented 2020-09-27 04:46:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 10

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 10](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R10) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_10_7)
icex2 commented 2020-09-27 04:46:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 13

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 13](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R13) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_13_13)
icex2 commented 2020-09-27 04:46:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

Commented on doc/sdvxhook/vigem-sdvxio.md line 22

changed this line in version 3 of the diff

In GitLab by @xyen on Sep 27, 2020, 03:46 Commented on [doc/sdvxhook/vigem-sdvxio.md line 22](https://github.com/djhackersdev/bemanitools/compare/addcb25242b403e3403109e803487a7b3970789d..3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#diff-4843c009d69a482a3a7e3988a748d612R22) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8#016a6f3d6be81c0a35c47576033bc4ed76b92b5a_22_21)
icex2 commented 2020-09-27 04:46:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:46

added 1 commit

  • fc3cb5d9 - vigem-sdvxio: Add relative mode and address comments

Compare with previous version

In GitLab by @xyen on Sep 27, 2020, 03:46 added 1 commit <ul><li>fc3cb5d9 - vigem-sdvxio: Add relative mode and address comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1317&start_sha=3bda5001a5c7dc66c3453f42b3e94bff987b8aa8)
icex2 commented 2020-09-27 04:47:17 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:47

resolved all threads

In GitLab by @xyen on Sep 27, 2020, 03:47 resolved all threads
icex2 commented 2020-09-27 04:53:01 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 03:53

added 1 commit

  • f7f367ae - vigem-sdvxio: Add relative mode and address comments

Compare with previous version

In GitLab by @xyen on Sep 27, 2020, 03:53 added 1 commit <ul><li>f7f367ae - vigem-sdvxio: Add relative mode and address comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1318&start_sha=fc3cb5d92da6a6b15539eea720f4de9d22dea863)
icex2 commented 2020-09-27 05:00:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 04:00

added 1 commit

  • c5c5e322 - vigem-sdvxio: Add relative mode and address comments

Compare with previous version

In GitLab by @xyen on Sep 27, 2020, 04:00 added 1 commit <ul><li>c5c5e322 - vigem-sdvxio: Add relative mode and address comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1319&start_sha=f7f367aea990a26db92ac2e8496c32cac2d0629b)
icex2 commented 2020-09-27 05:54:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 04:54

added 1 commit

  • be54615d - vigem-sdvxio: Add relative mode and address comments

Compare with previous version

In GitLab by @xyen on Sep 27, 2020, 04:54 added 1 commit <ul><li>be54615d - vigem-sdvxio: Add relative mode and address comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1320&start_sha=c5c5e322ed95057ccfafb7c5b48bc243dc417035)
icex2 commented 2020-09-27 08:54:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 27, 2020, 07:54

added 1 commit

  • 8055ab86 - vigem-sdvxio: Add relative mode and address comments

Compare with previous version

In GitLab by @xyen on Sep 27, 2020, 07:54 added 1 commit <ul><li>8055ab86 - vigem-sdvxio: Add relative mode and address comments</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/52/diffs?diff_id=1321&start_sha=be54615d774549240582d250c19eade60d938569)
icex2 commented 2020-09-27 16:57:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

approved this merge request

approved this merge request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#153