Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Add jbiotest for testing jubeat IO impls - [merged] #151

New Issue
Closed
opened 2020-08-31 03:18:30 +03:00 by icex2 · 13 comments
icex2 commented 2020-08-31 03:18:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Aug 31, 2020, 02:18

Merges jbiotest -> master

Just like iidxiotest, but for Jubeat!

In GitLab by @mon on Aug 31, 2020, 02:18 _Merges jbiotest -> master_ Just like iidxiotest, but for Jubeat!
icex2 commented 2020-08-31 12:57:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Aug 31, 2020, 11:57

make code-format
In GitLab by @xyen on Aug 31, 2020, 11:57 ``` make code-format ```
icex2 commented 2020-08-31 13:08:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Aug 31, 2020, 12:08

added 1 commit

  • 53a1abfd - Formatting

Compare with previous version

In GitLab by @mon on Aug 31, 2020, 12:08 added 1 commit <ul><li>53a1abfd - Formatting</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1294&start_sha=6f4ac112a887bb3b95e29d77303288dc306f6049)
icex2 commented 2020-08-31 21:21:04 +03:00 (Migrated from github.com)
Copy Link
Copy Source
 * Tool to test your implementations of jbio.
```suggestion:-0+0 * Tool to test your implementations of jbio. ```
icex2 commented 2020-08-31 21:23:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: I personally dislike inlining enums as this tends to clutter the actual code. Do you mind moving the enum to the top of this module before the rgb_t struct?

Nit: I personally dislike inlining enums as this tends to clutter the actual code. Do you mind moving the enum to the top of this module before the `rgb_t` struct?
icex2 commented 2020-08-31 21:26:02 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Great contribution for jubeat development and testing.

Great contribution for jubeat development and testing.
icex2 commented 2020-09-12 08:13:17 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:13

Commented on src/main/jbiotest/main.c line 20

changed this line in version 3 of the diff

In GitLab by @mon on Sep 12, 2020, 07:13 Commented on [src/main/jbiotest/main.c line 20](https://github.com/djhackersdev/bemanitools/compare/9fa83cef641a1f4e2904b13976f428b419d84261..53a1abfd469f20784a366a5f84dba75945e699ca#diff-5562add25ddfb8c13be5ef3b856a1078R20) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1310&start_sha=53a1abfd469f20784a366a5f84dba75945e699ca#ead1b0eb2e86d3672099b4b1cae7bb733240a96a_20_20)
icex2 commented 2020-09-12 08:13:17 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:13

added 1 commit

  • c3213920 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

In GitLab by @mon on Sep 12, 2020, 07:13 added 1 commit <ul><li>c3213920 - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1310&start_sha=53a1abfd469f20784a366a5f84dba75945e699ca)
icex2 commented 2020-09-12 08:16:56 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:16

Commented on src/main/jbiotest/main.c line 49

changed this line in version 4 of the diff

In GitLab by @mon on Sep 12, 2020, 07:16 Commented on [src/main/jbiotest/main.c line 49](https://github.com/djhackersdev/bemanitools/compare/9fa83cef641a1f4e2904b13976f428b419d84261..c3213920dcb1d29ea06375e5a62ae8aa7c7d5945#diff-5562add25ddfb8c13be5ef3b856a1078R49) changed this line in [version 4 of the diff](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1311&start_sha=c3213920dcb1d29ea06375e5a62ae8aa7c7d5945#ead1b0eb2e86d3672099b4b1cae7bb733240a96a_49_55)
icex2 commented 2020-09-12 08:16:56 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:16

added 1 commit

  • eb02a717 - Remove inline enum

Compare with previous version

In GitLab by @mon on Sep 12, 2020, 07:16 added 1 commit <ul><li>eb02a717 - Remove inline enum</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1311&start_sha=c3213920dcb1d29ea06375e5a62ae8aa7c7d5945)
icex2 commented 2020-09-12 08:16:58 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:16

resolved all threads

In GitLab by @mon on Sep 12, 2020, 07:16 resolved all threads
icex2 commented 2020-09-12 08:17:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 07:17

Alright, should be good!

In GitLab by @mon on Sep 12, 2020, 07:17 Alright, should be good!
icex2 commented 2020-09-12 12:06:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 12, 2020, 11:06

approved this merge request

In GitLab by @xyen on Sep 12, 2020, 11:06 approved this merge request
icex2 commented 2020-09-12 12:11:41 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @mon on Sep 12, 2020, 11:11

added 21 commits

  • eb02a717...d3f1a9b1 - 17 commits from branch djhackers:master
  • 173131a4 - Add jbiotest for testing jubeat IO impls
  • e5a7fcd5 - Formatting
  • 271a112f - Apply 1 suggestion(s) to 1 file(s)
  • 03acf15e - Remove inline enum

Compare with previous version

In GitLab by @mon on Sep 12, 2020, 11:11 added 21 commits <ul><li>eb02a717...d3f1a9b1 - 17 commits from branch <code>djhackers:master</code></li><li>173131a4 - Add jbiotest for testing jubeat IO impls</li><li>e5a7fcd5 - Formatting</li><li>271a112f - Apply 1 suggestion(s) to 1 file(s)</li><li>03acf15e - Remove inline enum</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/50/diffs?diff_id=1312&start_sha=eb02a7179be3f22e11258456a4efdf903c7eaaf4)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#151