Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Improve documention regarding contributing/bug reporting - [merged] #149

New Issue
Closed
opened 2020-08-21 17:17:57 +03:00 by icex2 · 10 comments
icex2 commented 2020-08-21 17:17:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Merges launcher-inject-log-file-bat -> master

Since people have trouble switching on the flag when things break
and because this is rather common to have, make launcher and inject
always write to log files by adding the cmd param in the bat files
of all games.

Also point out in the issue template to include one of the files.

Focus changed:

  • Improve bug report template to include concrete information how to enable logging.
  • Improve contributing documentation
_Merges launcher-inject-log-file-bat -> master_ ~~Since people have trouble switching on the flag when things break and because this is rather common to have, make launcher and inject always write to log files by adding the cmd param in the bat files of all games.~~ ~~Also point out in the issue template to include one of the files.~~ Focus changed: * Improve bug report template to include concrete information how to enable logging. * Improve contributing documentation
icex2 commented 2020-09-02 22:53:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 2, 2020, 21:53

approved this merge request

In GitLab by @xyen on Sep 2, 2020, 21:53 approved this merge request
icex2 commented 2020-09-02 22:53:52 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Sep 2, 2020, 21:53

unapproved this merge request

In GitLab by @xyen on Sep 2, 2020, 21:53 unapproved this merge request
icex2 commented 2020-09-02 23:06:27 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Note by @xyen this introduces high latency with SDVX that has log calls in the main loop.

Note by @xyen this introduces high latency with SDVX that has log calls in the main loop.
icex2 commented 2020-11-08 14:03:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 59 commits

  • cf0d3e87...64e8f768 - 58 commits from branch master
  • bb9df7ef - gitlab: Update bug template to point out how to log to file

Compare with previous version

added 59 commits <ul><li>cf0d3e87...64e8f768 - 58 commits from branch <code>master</code></li><li>bb9df7ef - gitlab: Update bug template to point out how to log to file</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/48/diffs?diff_id=1347&start_sha=cf0d3e87d7966a0a8823c2e2c8b87803b4b5466c)
icex2 commented 2020-11-08 14:04:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Removed the commit that turns on always logging to file. Instead, improve readme and bug template with instructions how to submit a but report.

Removed the commit that turns on always logging to file. Instead, improve readme and bug template with instructions how to submit a but report.
icex2 commented 2020-11-08 14:59:09 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 1 commit

  • 83a6eea2 - Improve contributing documentation

Compare with previous version

added 1 commit <ul><li>83a6eea2 - Improve contributing documentation</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/48/diffs?diff_id=1348&start_sha=bb9df7ef8c367dc5947de298c7151e9c128a1d1f)
icex2 commented 2020-11-08 15:02:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 1 commit

  • b1f42c85 - Improve contributing documentation

Compare with previous version

added 1 commit <ul><li>b1f42c85 - Improve contributing documentation</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/48/diffs?diff_id=1349&start_sha=83a6eea29ddce7a3b92aeb873c591e1440238d7b)
icex2 commented 2020-11-08 15:04:53 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 1 commit

  • 74880119 - Improve contributing documentation

Compare with previous version

added 1 commit <ul><li>74880119 - Improve contributing documentation</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/48/diffs?diff_id=1350&start_sha=b1f42c8594246e62b1e689fcafb98fe6f82aa200)
icex2 commented 2020-11-08 15:05:49 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 1 commit

  • ae9db4a8 - Improve contributing documentation

Compare with previous version

added 1 commit <ul><li>ae9db4a8 - Improve contributing documentation</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/48/diffs?diff_id=1351&start_sha=748801197e3bb2527d0b6194cd7a498c4f5a5192)
icex2 commented 2020-11-08 15:11:49 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 8, 2020, 13:11

approved this merge request

In GitLab by @xyen on Nov 8, 2020, 13:11 approved this merge request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#149