Note: This MR introduces changes in every hook library. However, since these are rather straight forward, I don't expect anything major to break and won't test all of them either.
_Merges update-capnhook -> master_
Update the `src/main/hook` submodule to the latest from: https://github.com/decafcode/capnhook
Adapt everything in BT to new capnhook API (changes), this includes
* Renaming of functions (iohook_invoke_next)
* Slight interface changes (com_proxy_wrap, iohook_push_handler)
* De-duplicate stuff from utils (iobuf, hr)
Note: This MR introduces changes in every hook library. However, since these are rather straight forward, I don't expect anything major to break and won't test all of them either.
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on [src/main/camhook/cam.c line 348](https://github.com/djhackersdev/bemanitools/compare/3ab55b9ef02a1e052b4ca16c61a021092eced6d1..ecda787f980646f965c814519389a708690f7540#diff-cc4d7cae74a7918058230af46b19ad1eR348)
"proxyu"
Instead of exploding every one of these into iohook_push_handler calls, we should implement a helper function for it, as I think having the list of irp handlers kept as-is is cleaner.
Additionally, this reduces the number of actual changes needed to review.
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on [src/main/bsthook/dllmain.c line 119](https://github.com/djhackersdev/bemanitools/compare/9fa83cef641a1f4e2904b13976f428b419d84261..5de9fdee437e8aba712627c48e3080ac289f93b7#diff-cfce9d99009a76ddd49ded9e1ed92f34L119)
Instead of exploding every one of these into `iohook_push_handler` calls, we should implement a helper function for it, as I think having the list of irp handlers kept as-is is cleaner.
Additionally, this reduces the number of actual changes needed to review.
A lot cleaner / easier to review to just add a wrapper that calls iohook_invoke_next from irp_invoke_next.
Given the number of emulation devices that call this.
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on [src/main/bio2emu/emu.c line 72](https://github.com/djhackersdev/bemanitools/compare/9fa83cef641a1f4e2904b13976f428b419d84261..5de9fdee437e8aba712627c48e3080ac289f93b7#diff-8acdfbf456767b53ede5d020eccc5b89L72)
A lot cleaner / easier to review to just add a wrapper that calls `iohook_invoke_next` from `irp_invoke_next`.
Given the number of emulation devices that call this.
I think the single calls make an overall cleaner API and eliminates having to put each handler into an array before being torn apart by the helper or the internal implementation again. Considering we have a max of 4-5 calls so far, the overall code clutter is still reasonable when calling the method multiple times with different handlers, imo.
I think the single calls make an overall cleaner API and eliminates having to put each handler into an array before being torn apart by the helper or the internal implementation again. Considering we have a max of 4-5 calls so far, the overall code clutter is still reasonable when calling the method multiple times with different handlers, imo.
added 1 commit
<ul><li>8da99f76 - Adapt everything in BT5 to new capnhook API</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/47/diffs?diff_id=1295&start_sha=ecda787f980646f965c814519389a708690f7540)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/47/diffs?diff_id=1295&start_sha=ecda787f980646f965c814519389a708690f7540#2651b7502fcb1138e912f7bcfea9d7bed919a27d_348_348)
on further thought, I think it's fine as-is, if we're keeping the other changes as well
In GitLab by @xyen on Sep 1, 2020, 04:37
Commented on [src/main/bio2emu/emu.c line 72](https://github.com/djhackersdev/bemanitools/compare/9fa83cef641a1f4e2904b13976f428b419d84261..5de9fdee437e8aba712627c48e3080ac289f93b7#diff-8acdfbf456767b53ede5d020eccc5b89L72)
on further thought, I think it's fine as-is, if we're keeping the other changes as well
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Merges update-capnhook -> master
Update the
src/main/hooksubmodule to the latest from: https://github.com/decafcode/capnhookAdapt everything in BT to new capnhook API (changes), this includes
Note: This MR introduces changes in every hook library. However, since these are rather straight forward, I don't expect anything major to break and won't test all of them either.
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on src/main/camhook/cam.c line 348
"proxyu"
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on src/main/bsthook/dllmain.c line 119
Instead of exploding every one of these into
iohook_push_handlercalls, we should implement a helper function for it, as I think having the list of irp handlers kept as-is is cleaner.Additionally, this reduces the number of actual changes needed to review.
In GitLab by @xyen on Aug 21, 2020, 21:35
Commented on src/main/bio2emu/emu.c line 72
A lot cleaner / easier to review to just add a wrapper that calls
iohook_invoke_nextfromirp_invoke_next.Given the number of emulation devices that call this.
I think the single calls make an overall cleaner API and eliminates having to put each handler into an array before being torn apart by the helper or the internal implementation again. Considering we have a max of 4-5 calls so far, the overall code clutter is still reasonable when calling the method multiple times with different handlers, imo.
added 1 commit
Compare with previous version
changed this line in version 2 of the diff
Fixed.
Do you suggest having
irp_invoke_nextas an alias for the newiohook_invoke_next?In GitLab by @xyen on Sep 1, 2020, 04:37
Commented on src/main/bio2emu/emu.c line 72
on further thought, I think it's fine as-is, if we're keeping the other changes as well
resolved all threads
In GitLab by @xyen on Sep 2, 2020, 21:32
approved this merge request
added 18 commits
masterb777396e- hook: Update capnhook source files from latest master5de9fdee- Adapt everything in BT5 to new capnhook APICompare with previous version