Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Included SMX md file with step-by-step instructions and additional info. - [merged] #139

New Issue
Closed
opened 2020-06-28 21:54:24 +03:00 by icex2 · 20 comments
icex2 commented 2020-06-28 21:54:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 20:54

Merges master -> master

Summary

As-per suggested, included a md readme for SMX (Stepmaniax) pad usage with DDR data.

Description

Includes a step-by-step breakdown of getting things working, as well as an FAQ of sorts, based on common issues.

In GitLab by @Androopy on Jun 28, 2020, 20:54 _Merges master -> master_ ## Summary As-per suggested, included a md readme for SMX (Stepmaniax) pad usage with DDR data. ## Description Includes a step-by-step breakdown of getting things working, as well as an FAQ of sorts, based on common issues.
icex2 commented 2020-06-28 22:10:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: StepManiaX, Kyle will sue for that spelling. :P

Nit: `StepManiaX`, Kyle will sue for that spelling. :P
icex2 commented 2020-06-28 22:10:49 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Remove : at the end of the line

Nit: Remove `:` at the end of the line
icex2 commented 2020-06-28 22:10:59 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Remove : at the end of the line

Nit: Remove `:` at the end of the line
icex2 commented 2020-06-28 22:11:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In general, it is recommended to backquote, e.g. myFile, any filenames and paths -> SMX.dll

In general, it is recommended to backquote, e.g. `myFile`, any filenames and paths -> `SMX.dll`
icex2 commented 2020-06-28 22:12:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Great piece of documentation. I just addressed a few minor things to polish it. Can you move that to doc/ddrhook/ddrio-smx.md to align with how the other documentation is stored?

Great piece of documentation. I just addressed a few minor things to polish it. Can you move that to `doc/ddrhook/ddrio-smx.md` to align with how the other documentation is stored?
icex2 commented 2020-06-28 22:37:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:37

Commented on ddrio-smx.md line 2

changed this line in version 2 of the diff

In GitLab by @Androopy on Jun 28, 2020, 21:37 Commented on [ddrio-smx.md line 2](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..3a510c2d2eb14468908a439c5306d3311abe429a#diff-0b4745214854f1857c46c5a271bc8297R2) changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/38/diffs?diff_id=1247&start_sha=3a510c2d2eb14468908a439c5306d3311abe429a#03f1f4512503aae88e0ba16f21bc40916afa3c52_2_0)
icex2 commented 2020-06-28 22:37:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:37

Commented on ddrio-smx.md line 4

changed this line in version 2 of the diff

In GitLab by @Androopy on Jun 28, 2020, 21:37 Commented on [ddrio-smx.md line 4](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..3a510c2d2eb14468908a439c5306d3311abe429a#diff-0b4745214854f1857c46c5a271bc8297R4) changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/38/diffs?diff_id=1247&start_sha=3a510c2d2eb14468908a439c5306d3311abe429a#03f1f4512503aae88e0ba16f21bc40916afa3c52_4_0)
icex2 commented 2020-06-28 22:37:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:37

Commented on ddrio-smx.md line 11

changed this line in version 2 of the diff

In GitLab by @Androopy on Jun 28, 2020, 21:37 Commented on [ddrio-smx.md line 11](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..3a510c2d2eb14468908a439c5306d3311abe429a#diff-0b4745214854f1857c46c5a271bc8297R11) changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/38/diffs?diff_id=1247&start_sha=3a510c2d2eb14468908a439c5306d3311abe429a#03f1f4512503aae88e0ba16f21bc40916afa3c52_11_0)
icex2 commented 2020-06-28 22:37:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:37

Commented on ddrio-smx.md line 5

changed this line in version 2 of the diff

In GitLab by @Androopy on Jun 28, 2020, 21:37 Commented on [ddrio-smx.md line 5](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..3a510c2d2eb14468908a439c5306d3311abe429a#diff-0b4745214854f1857c46c5a271bc8297R5) changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/38/diffs?diff_id=1247&start_sha=3a510c2d2eb14468908a439c5306d3311abe429a#03f1f4512503aae88e0ba16f21bc40916afa3c52_5_0)
icex2 commented 2020-06-28 22:37:34 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:37

added 1 commit

  • c59c44ef - Moved location of `ddrio-smx.md` to `doc/ddrhook/ddrio-smx.md`, fixed some...

Compare with previous version

In GitLab by @Androopy on Jun 28, 2020, 21:37 added 1 commit <ul><li>c59c44ef - Moved location of `ddrio-smx.md` to `doc/ddrhook/ddrio-smx.md`, fixed some...</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/38/diffs?diff_id=1247&start_sha=3a510c2d2eb14468908a439c5306d3311abe429a)
icex2 commented 2020-06-28 22:39:01 +03:00 (Migrated from github.com)
Copy Link
Copy Source

resolved all threads

resolved all threads
icex2 commented 2020-06-28 22:39:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nice, thanks. LGTM

Nice, thanks. LGTM
icex2 commented 2020-06-28 22:39:36 +03:00 (Migrated from github.com)
Copy Link
Copy Source

enabled an automatic merge when the pipeline for c59c44efb6 succeeds

enabled an automatic merge when the pipeline for c59c44efb62fe582f6a445d6886d8b5b603e7813 succeeds
icex2 commented 2020-06-28 22:40:55 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Androopy on Jun 28, 2020, 21:40

Thanks! I feel confident enough to contribute a bit more now. :)

In GitLab by @Androopy on Jun 28, 2020, 21:40 Thanks! I feel confident enough to contribute a bit more now. :)
icex2 commented 2020-06-28 22:41:33 +03:00 (Migrated from github.com)
Copy Link
Copy Source

That is great to hear. Looking forward to further contributions! 👍

That is great to hear. Looking forward to further contributions! :+1:
icex2 commented 2020-06-29 07:58:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 29, 2020, 06:58

resolved all threads

In GitLab by @xyen on Jun 29, 2020, 06:58 resolved all threads
icex2 commented 2020-06-29 07:58:45 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 29, 2020, 06:58

canceled the automatic merge

In GitLab by @xyen on Jun 29, 2020, 06:58 canceled the automatic merge
icex2 commented 2020-06-29 07:58:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 29, 2020, 06:58

merged

In GitLab by @xyen on Jun 29, 2020, 06:58 merged
icex2 commented 2020-06-29 07:59:02 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Jun 29, 2020, 06:59

manually merging since the pipeline appears to be broken.

In GitLab by @xyen on Jun 29, 2020, 06:59 manually merging since the pipeline appears to be broken.
icex2 commented 2020-06-29 13:45:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @Corin on Jun 29, 2020, 12:45

Resolved, runner server appeared to be having a bit of a moment.

In GitLab by @Corin on Jun 29, 2020, 12:45 Resolved, runner server appeared to be having a bit of a moment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#139