Not particularly, in fact I haven't looked through the older versions of MDX to see if it conflicts with any command line options that the game itself recognizes.
I'm open to alternative suggestions for the option character.
In GitLab by @tau on Jun 26, 2020, 19:42
Commented on [src/main/ddrhook/dllmain.c line 82](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..813a71d8ebe0f996262c09dae43873c00e56f29f#diff-1705965ab9f6c9ea6aa0cd95296240ddR82)
Not particularly, in fact I haven't looked through the older versions of MDX to see if it conflicts with any command line options that the game itself recognizes.
I'm open to alternative suggestions for the option character.
ok. Just checked KDX, it responds to (case insensitive) L, M, N, O, S, W. So those should be avoided. I'll change it to lowercase u.
In GitLab by @tau on Jun 26, 2020, 19:46
Commented on [src/main/ddrhook/dllmain.c line 82](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..813a71d8ebe0f996262c09dae43873c00e56f29f#diff-1705965ab9f6c9ea6aa0cd95296240ddR82)
ok. Just checked KDX, it responds to (case insensitive) L, M, N, O, S, W. So those should be avoided. I'll change it to lowercase u.
In GitLab by @tau on Jun 26, 2020, 19:46
Commented on [src/main/ddrhook/dllmain.c line 82](https://github.com/djhackersdev/bemanitools/compare/d626bfc987809721554561fe9ccd5d6a13fc0fc7..813a71d8ebe0f996262c09dae43873c00e56f29f#diff-1705965ab9f6c9ea6aa0cd95296240ddR82)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/37/diffs?diff_id=1245&start_sha=813a71d8ebe0f996262c09dae43873c00e56f29f#ceca55728b982df3a4b235cb7f2e669907bb4ee6_82_82)
In GitLab by @tau on Jun 26, 2020, 19:46
added 1 commit
<ul><li>eaff5dda - Add ddrhook "COM4" passthrough mode</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/37/diffs?diff_id=1245&start_sha=813a71d8ebe0f996262c09dae43873c00e56f29f)
I'd add some sort of comment to either dist/ddr or doc/ and describe what exactly the flag is / does.
Otherwise lgtm as well.
In GitLab by @xyen on Jun 26, 2020, 23:00
I'd add some sort of comment to either dist/ddr or doc/ and describe what exactly the flag is / does.
Otherwise lgtm as well.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @tau on Jun 26, 2020, 02:50
Merges feature/ddrhook-com4 -> master
Any reason for the upper case 'U' instead of lower case 'u' here?
In GitLab by @tau on Jun 26, 2020, 19:42
Commented on src/main/ddrhook/dllmain.c line 82
Not particularly, in fact I haven't looked through the older versions of MDX to see if it conflicts with any command line options that the game itself recognizes.
I'm open to alternative suggestions for the option character.
Since this is at the hook level, I would stick to lower-case, e.g. 'u'. IIRC the loader uses the upper-case parameters.
In GitLab by @tau on Jun 26, 2020, 19:46
Commented on src/main/ddrhook/dllmain.c line 82
ok. Just checked KDX, it responds to (case insensitive) L, M, N, O, S, W. So those should be avoided. I'll change it to lowercase u.
In GitLab by @tau on Jun 26, 2020, 19:46
Commented on src/main/ddrhook/dllmain.c line 82
changed this line in version 2 of the diff
In GitLab by @tau on Jun 26, 2020, 19:46
added 1 commit
Compare with previous version
lgtm
In GitLab by @xyen on Jun 26, 2020, 23:00
I'd add some sort of comment to either dist/ddr or doc/ and describe what exactly the flag is / does.
Otherwise lgtm as well.
closed
Just merged this manually to master since the branch required a rebase.