jbhook: add adapter hook - [merged] #134

Closed
opened 2020-06-13 00:54:22 +03:00 by icex2 · 4 comments
icex2 commented 2020-06-13 00:54:22 +03:00 (Migrated from github.com)

In GitLab by @Oromit on Jun 12, 2020, 23:54

Merges fix_jbhook -> master

Not sure if this was simply forgotten, or there's a reason for it being missing.
But without this, I was unable to properly connect to some networks via VPN.

In GitLab by @Oromit on Jun 12, 2020, 23:54 _Merges fix_jbhook -> master_ Not sure if this was simply forgotten, or there's a reason for it being missing. But without this, I was unable to properly connect to some networks via VPN.
icex2 commented 2020-06-13 07:25:40 +03:00 (Migrated from github.com)

In GitLab by @xyen on Jun 13, 2020, 06:25

lgtm, I think it was missing because it was added separately.

That being said, should probably provide some way of overwriting the IP, instead of it just picking the "best", by providing a way to pass an IP in and calling adapter_hook_override().

In GitLab by @xyen on Jun 13, 2020, 06:25 lgtm, I think it was missing because it was added separately. That being said, should probably provide some way of overwriting the IP, instead of it just picking the "best", by providing a way to pass an IP in and calling `adapter_hook_override()`.
icex2 commented 2020-06-14 02:31:46 +03:00 (Migrated from github.com)

Also LGTM.

Also LGTM.
icex2 commented 2020-06-14 03:22:26 +03:00 (Migrated from github.com)

In GitLab by @Oromit on Jun 14, 2020, 02:22

added 2 commits

  • 2b95e25e - 1 commit from branch djhackers:master
  • 1656fecc - jbhook: add adapter hook

Compare with previous version

In GitLab by @Oromit on Jun 14, 2020, 02:22 added 2 commits <ul><li>2b95e25e - 1 commit from branch <code>djhackers:master</code></li><li>1656fecc - jbhook: add adapter hook</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/33/diffs?diff_id=1233&start_sha=b7f0914ed6610fe2b7a4fa93b529a63a9686c710)
icex2 commented 2020-06-14 12:39:26 +03:00 (Migrated from github.com)

merged

merged
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#134