popn additional hid lights - [merged] #133

Closed
opened 2020-06-08 12:26:35 +03:00 by icex2 · 2 comments
icex2 commented 2020-06-08 12:26:35 +03:00 (Migrated from github.com)

In GitLab by @shtokopep on Jun 8, 2020, 11:26

Merges master -> master

Pop'n Music mappings in the config tool allow to map only button 1 to 9 as HID lights. I added changes so the remaining lights from an SD cab can be mapped as well (top lamp 1 to 5, left and right lamps 1 and 2).

I realize there's no BT5 support for popn for now, but I made these changes along with new ezusb.dll patches for the old popn15 to 18 (not included here cause that way of patching dll is not BT5 spirit), and I think it'd be best to reserve the #define IDs now so I don't have to change them again in the future when geninput gets updated.

In GitLab by @shtokopep on Jun 8, 2020, 11:26 _Merges master -> master_ Pop'n Music mappings in the config tool allow to map only button 1 to 9 as HID lights. I added changes so the remaining lights from an SD cab can be mapped as well (top lamp 1 to 5, left and right lamps 1 and 2). I realize there's no BT5 support for popn for now, but I made these changes along with new ezusb.dll patches for the old popn15 to 18 (not included here cause that way of patching dll is not BT5 spirit), and I think it'd be best to reserve the #define IDs now so I don't have to change them again in the future when geninput gets updated.
icex2 commented 2020-06-14 02:37:58 +03:00 (Migrated from github.com)

LGTM. Since there is no popn support, yet, I don't see an issue with having them around already. Thanks for your contribution.

LGTM. Since there is no popn support, yet, I don't see an issue with having them around already. Thanks for your contribution.
icex2 commented 2020-06-14 02:38:06 +03:00 (Migrated from github.com)

merged

merged
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#133