aciodrv: Make init more consistent by reading until we actually get a 0xAA - [merged] #132

Closed
opened 2020-05-27 18:52:18 +03:00 by icex2 · 6 comments
icex2 commented 2020-05-27 18:52:18 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 27, 2020, 17:52

Merges sdvxio_kfca_init_fix -> master

reboots / command interruptions will cause incorrect state on device side

quick fix, automerging

In GitLab by @xyen on May 27, 2020, 17:52 _Merges sdvxio_kfca_init_fix -> master_ reboots / command interruptions will cause incorrect state on device side quick fix, automerging
icex2 commented 2020-05-27 18:52:28 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 27, 2020, 17:52

merged

In GitLab by @xyen on May 27, 2020, 17:52 merged
icex2 commented 2020-05-27 20:58:12 +03:00 (Migrated from github.com)

Just wondering, might this be something that we want toggleable using a configuration switch so it's easier to get debug logs from anyone having issues?

Just wondering, might this be something that we want toggleable using a configuration switch so it's easier to get debug logs from anyone having issues?
icex2 commented 2020-05-27 21:01:03 +03:00 (Migrated from github.com)

Note: Seeing that fix and IIRC, I have seen inconsistent issues with booting older IIDX games and ACIO, e.g. iidx 13, throwing random card device init errors or something along the lines. Which games and versions made you add that fix?

Note: Seeing that fix and IIRC, I have seen inconsistent issues with booting older IIDX games and ACIO, e.g. iidx 13, throwing random card device init errors or something along the lines. Which games and versions made you add that fix?
icex2 commented 2020-05-27 23:58:53 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 27, 2020, 22:58

Commented on src/main/aciodrv/device.c line 31

This wouldn't cause init errors, this would just cause a hang on boot. IIDX 13 throwing weird errors on ICCA init would probably be something else (unless you set some flag when it finishes initing, and it's in a separate thread, and that times out?).

This was for sdvxio-kfca.

In GitLab by @xyen on May 27, 2020, 22:58 Commented on [src/main/aciodrv/device.c line 31](https://github.com/djhackersdev/bemanitools/compare/de03772905c0070920400383a5597046cdde6c97..520cdf15ac332fd28de370b22a4d30645c8d4610#diff-1c1a2ad8deb60fa4bb473a3e4f9e4732R31) This wouldn't cause init errors, this would just cause a hang on boot. IIDX 13 throwing weird errors on ICCA init would probably be something else (unless you set some flag when it finishes initing, and it's in a separate thread, and that times out?). This was for sdvxio-kfca.
icex2 commented 2020-05-28 00:01:05 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 27, 2020, 23:01

Commented on src/main/aciodrv/device.c line 324

Maybe, although it'd be caller specific, as aciodrv is called by other things, and doesn't have a standalone config.

In GitLab by @xyen on May 27, 2020, 23:01 Commented on [src/main/aciodrv/device.c line 324](https://github.com/djhackersdev/bemanitools/compare/de03772905c0070920400383a5597046cdde6c97..520cdf15ac332fd28de370b22a4d30645c8d4610#diff-1c1a2ad8deb60fa4bb473a3e4f9e4732R324) Maybe, although it'd be caller specific, as aciodrv is called by other things, and doesn't have a standalone config.
icex2 commented 2020-05-28 00:01:06 +03:00 (Migrated from github.com)

In GitLab by @xyen on May 27, 2020, 23:01

resolved all threads

In GitLab by @xyen on May 27, 2020, 23:01 resolved all threads
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#132