Bump jubeat heap size - [closed] #129

Closed
opened 2020-04-06 11:38:38 +03:00 by icex2 · 5 comments
icex2 commented 2020-04-06 11:38:38 +03:00 (Migrated from github.com)

In GitLab by @Felix on Apr 6, 2020, 10:38

Merges jb-heap -> master

In very rare instances, jubeat can run out of heap space causing property parsing to fail spectacularly and a lovely 5-1505-0000 System Error to appear. This took me a few hours to diagnose months ago.

In GitLab by @Felix on Apr 6, 2020, 10:38 _Merges jb-heap -> master_ In very rare instances, jubeat can run out of heap space causing property parsing to fail spectacularly and a lovely 5-1505-0000 System Error to appear. This took me a few hours to diagnose months ago.
icex2 commented 2020-04-06 23:44:30 +03:00 (Migrated from github.com)

LGTM. Do you know which versions of jubeat are affected by this or which ones you have tested and ran into this problem?

LGTM. Do you know which versions of jubeat are affected by this or which ones you have tested and ran into this problem?
icex2 commented 2020-04-07 11:27:35 +03:00 (Migrated from github.com)

In GitLab by @Felix on Apr 7, 2020, 10:27

@icex2 I ran into this problem on jubeat clan 2018081401 with clean data a few months ago.

I managed to get the original assertion message by hooking GFDbgSetReportFunc so the original debug report function runs instead of jubeat's handler which does no logging.

[2019/07/12 23:46:29] F:-: assertion failed 'prop != NULL' at system\title_db\title_db.cpp:l.1233("achievement_xml_load")

jubeat clan 2018081401 has a slightly larger achievement_info.xml so that may have caused the problem.

In GitLab by @Felix on Apr 7, 2020, 10:27 @icex2 I ran into this problem on jubeat clan 2018081401 with clean data a few months ago. I managed to get the original assertion message by hooking `GFDbgSetReportFunc` so the original debug report function runs instead of jubeat's handler which does no logging. ``` [2019/07/12 23:46:29] F:-: assertion failed 'prop != NULL' at system\title_db\title_db.cpp:l.1233("achievement_xml_load") ``` jubeat clan 2018081401 has a slightly larger `achievement_info.xml` so that may have caused the problem.
icex2 commented 2020-04-08 00:50:29 +03:00 (Migrated from github.com)

That sounds like some valuable information that's worth a brief documentation. Do you mind adding this to doc/dev? Doesn't have to be a full post-mortem or write-up as it's quite clear what this is about. Basically, stating the problem, implications and the solution you already provided in the issue description and your comment gets the documentation job done.

That sounds like some valuable information that's worth a brief documentation. Do you mind adding this to `doc/dev`? Doesn't have to be a full post-mortem or write-up as it's quite clear what this is about. Basically, stating the problem, implications and the solution you already provided in the issue description and your comment gets the documentation job done.
icex2 commented 2020-04-20 22:30:15 +03:00 (Migrated from github.com)

Bumping as a reminder that this is still open. Any comments on my request?

Bumping as a reminder that this is still open. Any comments on my request?
icex2 commented 2020-12-31 20:00:02 +03:00 (Migrated from github.com)

!73 follows up to this.

!73 follows up to this.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#129