Regarding technical aspects, LGTM. However, I think we should be careful with the naming as the "hook" postfix in modules implies that this is an actual hook library you can use. At least that's the naming scheme the code base has followed so far and I think we should stick to this for consistency and to avoid confusion.
Therefore, I suggest renaming the "asiohook" module to just "asio". Same for "dinputhook" to just "dinput8".
Regarding technical aspects, LGTM. However, I think we should be careful with the naming as the "hook" postfix in modules implies that this is an actual hook library you can use. At least that's the naming scheme the code base has followed so far and I think we should stick to this for consistency and to avoid confusion.
Therefore, I suggest renaming the "asiohook" module to just "asio". Same for "dinputhook" to just "dinput8".
Could support additional DirectInput versions if the other DirectInput*Create functions are hooked as the IDirectInputDevice8W implementation supports all the previous versions as the interfaces extend the previous version.
In GitLab by @Felix on Apr 5, 2020, 11:10
Commented on [src/main/dinputhook/dinput.c line 3](https://github.com/djhackersdev/bemanitools/compare/7c821ab64c19533493a3e3216cca9591ae117201..cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#diff-144b1dc5c4e5e6030950a3a14b84035eR3)
Could support additional DirectInput versions if the other `DirectInput*Create` functions are hooked as the `IDirectInputDevice8W` implementation supports all the previous versions as the interfaces extend the previous version.
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on [src/main/dinputhook/device_dinput8.c line 29](https://github.com/djhackersdev/bemanitools/compare/7c821ab64c19533493a3e3216cca9591ae117201..cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#diff-eeea181de005a7e25dc36c65eb14ee3bR29)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/27/diffs?diff_id=1185&start_sha=cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#545d46d80e985608449926942b520aeb65e34a39_29_0)
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on [src/main/dinputhook/dinput.c line 92](https://github.com/djhackersdev/bemanitools/compare/7c821ab64c19533493a3e3216cca9591ae117201..cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#diff-144b1dc5c4e5e6030950a3a14b84035eR92)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/27/diffs?diff_id=1185&start_sha=cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#c0ca81786d9968f7e984362e0f9766fdb0c4d604_92_0)
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on [src/main/dinputhook/dinput.c line 47](https://github.com/djhackersdev/bemanitools/compare/7c821ab64c19533493a3e3216cca9591ae117201..cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#diff-144b1dc5c4e5e6030950a3a14b84035eR47)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/27/diffs?diff_id=1185&start_sha=cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#c0ca81786d9968f7e984362e0f9766fdb0c4d604_47_0)
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on [src/main/dinputhook/dinput.c line 3](https://github.com/djhackersdev/bemanitools/compare/7c821ab64c19533493a3e3216cca9591ae117201..cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#diff-144b1dc5c4e5e6030950a3a14b84035eR3)
changed this line in [version 2 of the diff](/djhackers/bemanitools/-/merge_requests/27/diffs?diff_id=1185&start_sha=cfebbc2aae014efc8daf58ddad1ec595e39c5ab4#c0ca81786d9968f7e984362e0f9766fdb0c4d604_3_0)
In GitLab by @xyen on Apr 5, 2020, 11:18
added 1 commit
<ul><li>4f915e6d - dinput/asio: drop hook suffix</li></ul>
[Compare with previous version](/djhackers/bemanitools/-/merge_requests/27/diffs?diff_id=1185&start_sha=cfebbc2aae014efc8daf58ddad1ec595e39c5ab4)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @xyen on Apr 5, 2020, 10:46
Merges additional_hooks -> master
Adds some additional hooks in preparation for future games.
Nit: No empty lines between function blocks from here on.
Nit: Styleguide, new line spacing before and after control blocks.
Nit: Style
If this covers only dinput8, I suggest naming the whole module "dinput8hook". Apply this to files and functions as well for consistency.
Regarding technical aspects, LGTM. However, I think we should be careful with the naming as the "hook" postfix in modules implies that this is an actual hook library you can use. At least that's the naming scheme the code base has followed so far and I think we should stick to this for consistency and to avoid confusion.
Therefore, I suggest renaming the "asiohook" module to just "asio". Same for "dinputhook" to just "dinput8".
In GitLab by @Felix on Apr 5, 2020, 11:10
Commented on src/main/dinputhook/dinput.c line 3
Could support additional DirectInput versions if the other
DirectInput*Createfunctions are hooked as theIDirectInputDevice8Wimplementation supports all the previous versions as the interfaces extend the previous version.Wasn't aware of that feature. Thanks for the clarification.
In GitLab by @xyen on Apr 5, 2020, 11:17
resolved all threads
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on src/main/dinputhook/device_dinput8.c line 29
changed this line in version 2 of the diff
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on src/main/dinputhook/dinput.c line 92
changed this line in version 2 of the diff
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on src/main/dinputhook/dinput.c line 47
changed this line in version 2 of the diff
In GitLab by @xyen on Apr 5, 2020, 11:18
Commented on src/main/dinputhook/dinput.c line 3
changed this line in version 2 of the diff
In GitLab by @xyen on Apr 5, 2020, 11:18
added 1 commit
4f915e6d- dinput/asio: drop hook suffixCompare with previous version
In GitLab by @xyen on Apr 5, 2020, 11:18
merged