Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

launcher: Add before-hook support - [merged] #127

New Issue
Closed
opened 2020-04-05 09:38:23 +03:00 by icex2 · 8 comments
icex2 commented 2020-04-05 09:38:23 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 08:38

Merges before_hook -> master

Required to hook certain things that happen on module load / avs boot:

  • network adapter hooking for avs
  • envvar setting

Note: the logging facilities are NOT setup yet at this point
so these hooks cannot use avs for logging

In GitLab by @xyen on Apr 5, 2020, 08:38 _Merges before_hook -> master_ Required to hook certain things that happen on module load / avs boot: - network adapter hooking for avs - envvar setting Note: the logging facilities are NOT setup yet at this point so these hooks cannot use avs for logging
icex2 commented 2020-04-05 10:04:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 09:04

added 1 commit

  • 5f35e5b4 - launcher: Add before-hook support

Compare with previous version

In GitLab by @xyen on Apr 5, 2020, 09:04 added 1 commit <ul><li>5f35e5b4 - launcher: Add before-hook support</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/26/diffs?diff_id=1182&start_sha=5677c65f110d244ea5cda54784963c5d65f7d8c8)
icex2 commented 2020-04-05 11:36:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

👍 For improving code readability by moving this to a function.

:thumbsup: For improving code readability by moving this to a function.
icex2 commented 2020-04-05 11:38:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Suggestion: "Load pre-hook DLL loaded before avs boot"

Suggestion: "Load pre-hook DLL loaded before avs boot"
icex2 commented 2020-04-05 11:39:53 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Just a minor thing regarding the usage text, LGTM otherwise.

Just a minor thing regarding the usage text, LGTM otherwise.
icex2 commented 2020-04-05 11:42:18 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 10:42

Commented on src/main/launcher/options.c line 184

changed this line in version 3 of the diff

In GitLab by @xyen on Apr 5, 2020, 10:42 Commented on [src/main/launcher/options.c line 184](https://github.com/djhackersdev/bemanitools/compare/d76b7b6c9d8395a4088b218e062a3088efb6c071..5f35e5b4e5ac279435da44e80587c5d52db066eb#diff-4e5da459d0743a74c9ae895610118c23R184) changed this line in [version 3 of the diff](/djhackers/bemanitools/-/merge_requests/26/diffs?diff_id=1183&start_sha=5f35e5b4e5ac279435da44e80587c5d52db066eb#cb0d472147e51f96b165639897cef39038e46a27_184_184)
icex2 commented 2020-04-05 11:42:19 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 10:42

added 1 commit

  • 7c821ab6 - launcher: Add before-hook support

Compare with previous version

In GitLab by @xyen on Apr 5, 2020, 10:42 added 1 commit <ul><li>7c821ab6 - launcher: Add before-hook support</li></ul> [Compare with previous version](/djhackers/bemanitools/-/merge_requests/26/diffs?diff_id=1183&start_sha=5f35e5b4e5ac279435da44e80587c5d52db066eb)
icex2 commented 2020-04-05 11:42:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 10:42

resolved all threads

In GitLab by @xyen on Apr 5, 2020, 10:42 resolved all threads
icex2 commented 2020-04-05 11:42:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Apr 5, 2020, 10:42

merged

In GitLab by @xyen on Apr 5, 2020, 10:42 merged
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#127