Do you mind giving some brief context why this needs to be configurable? The default value looks reasonable and standard to me. Is there a use-case when you want to change this path?
Do you mind giving some brief context why this needs to be configurable? The default value looks reasonable and standard to me. Is there a use-case when you want to change this path?
The file doesn't actually exist normally, and there's no standardized place to put it right now. spicetools does prop/bootstrap.xml, but imo since it's only the unis stuff, it shouldn't be named that.
In GitLab by @xyen on Jan 14, 2020, 24:44
Commented on [src/main/sdvxhook2-cn/config-cn.h line 10](https://github.com/djhackersdev/bemanitools/compare/ec852f2c92a2693b2c9ae6805b4a7709630fe26f..6ac7a3c0f78e146abf6daa3f9e449a5198226561#diff-1b616da47360faddec0c1bf407de06b0R10)
The file doesn't actually exist normally, and there's no standardized place to put it right now. spicetools does prop/bootstrap.xml, but imo since it's only the unis stuff, it shouldn't be named that.
In GitLab by @xyen on Jan 14, 2020, 03:21
Commented on [src/main/sdvxhook2-cn/dllmain.c line 132](https://github.com/djhackersdev/bemanitools/compare/ec852f2c92a2693b2c9ae6805b4a7709630fe26f..df989b8cc5566f6b5c09859793def01e8193d33a#diff-beb574d8428e4ce95a5dde27af9df162R132)
changed this line in [version 2 of the diff](/djhackers/bemanitools/merge_requests/22/diffs?diff_id=1132&start_sha=df989b8cc5566f6b5c09859793def01e8193d33a#02bc02d5603c3a9e8828eda844e3dc33e77f3fa7_132_132)
In GitLab by @xyen on Jan 14, 2020, 03:21
added 1 commit
<ul><li>6ac7a3c0 - misc: touchup some comments</li></ul>
[Compare with previous version](/djhackers/bemanitools/merge_requests/22/diffs?diff_id=1132&start_sha=df989b8cc5566f6b5c09859793def01e8193d33a)
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In GitLab by @xyen on Jan 13, 2020, 22:20
Merges sdvx-cn -> master
In GitLab by @xyen on Jan 13, 2020, 22:20
I guess I'm upstreaming this now, cause spice did it too.
Do you mind giving some brief context why this needs to be configurable? The default value looks reasonable and standard to me. Is there a use-case when you want to change this path?
Nit: Fix comment, "Hook library for SDVX 5 CN"
In GitLab by @xyen on Jan 14, 2020, 24:44
Commented on src/main/sdvxhook2-cn/config-cn.h line 10
The file doesn't actually exist normally, and there's no standardized place to put it right now. spicetools does prop/bootstrap.xml, but imo since it's only the unis stuff, it shouldn't be named that.
In GitLab by @xyen on Jan 14, 2020, 03:21
Commented on src/main/sdvxhook2-cn/dllmain.c line 132
changed this line in version 2 of the diff
In GitLab by @xyen on Jan 14, 2020, 03:21
added 1 commit
6ac7a3c0- misc: touchup some commentsCompare with previous version
In GitLab by @xyen on Jan 14, 2020, 03:22
resolved all threads
In GitLab by @xyen on Jan 14, 2020, 03:22
merged