launcher: make app_config.xml optional - [merged] #121

Closed
opened 2019-12-24 04:17:25 +03:00 by icex2 · 7 comments
icex2 commented 2019-12-24 04:17:25 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 24, 2019, 02:17

Merges launcher_optional_app_config -> master

In GitLab by @xyen on Dec 24, 2019, 02:17 _Merges launcher_optional_app_config -> master_
icex2 commented 2019-12-24 04:28:03 +03:00 (Migrated from github.com)

In GitLab by @tudor on Dec 24, 2019, 02:28

Commented on src/main/launcher/main.c line 251

<param/>?

In GitLab by @tudor on Dec 24, 2019, 02:28 Commented on [src/main/launcher/main.c line 251](https://github.com/djhackersdev/bemanitools/compare/634a3f5e7eeec0b3e166f592c6a1275ed55beeab..c24376b99cf056951becd25b160a3f1087c72cee#diff-5b44e1544fc6e2ee8377c919dd65f92dR251) ``<param/>``?
icex2 commented 2019-12-24 04:38:52 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 24, 2019, 02:38

Commented on src/main/launcher/main.c line 251

iirc. the boot param actually requires some contents to be here, this is also what bootstrap.xml passes by default for most games.

In GitLab by @xyen on Dec 24, 2019, 02:38 Commented on [src/main/launcher/main.c line 251](https://github.com/djhackersdev/bemanitools/compare/634a3f5e7eeec0b3e166f592c6a1275ed55beeab..c24376b99cf056951becd25b160a3f1087c72cee#diff-5b44e1544fc6e2ee8377c919dd65f92dR251) iirc. the boot param actually requires some contents to be here, this is also what bootstrap.xml passes by default for most games.
icex2 commented 2019-12-24 04:38:53 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 24, 2019, 02:38

resolved all threads

In GitLab by @xyen on Dec 24, 2019, 02:38 resolved all threads
icex2 commented 2019-12-24 04:41:10 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 24, 2019, 02:41

added 1 commit

  • c24376b9 - launcher: make app_config.xml optional

Compare with previous version

In GitLab by @xyen on Dec 24, 2019, 02:41 added 1 commit <ul><li>c24376b9 - launcher: make app_config.xml optional</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/20/diffs?diff_id=1120&start_sha=2edbcf998de122e31ba1c867289bbf212ff3bea5)
icex2 commented 2019-12-24 04:41:27 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 24, 2019, 02:41

merged

In GitLab by @xyen on Dec 24, 2019, 02:41 merged
icex2 commented 2019-12-24 04:43:44 +03:00 (Migrated from github.com)

In GitLab by @tudor on Dec 24, 2019, 02:43

Commented on src/main/launcher/main.c line 251

<component>
	<file>nostalgia.dll</file>
	<param/>
	<load_type>OS</load_type>
</component>
In GitLab by @tudor on Dec 24, 2019, 02:43 Commented on [src/main/launcher/main.c line 251](https://github.com/djhackersdev/bemanitools/compare/634a3f5e7eeec0b3e166f592c6a1275ed55beeab..c24376b99cf056951becd25b160a3f1087c72cee#diff-5b44e1544fc6e2ee8377c919dd65f92dR251) ```xml <component> <file>nostalgia.dll</file> <param/> <load_type>OS</load_type> </component> ```
icex2 commented 2019-12-25 12:19:21 +03:00 (Migrated from github.com)

In GitLab by @xyen on Dec 25, 2019, 10:19

Commented on src/main/launcher/main.c line 251

weird, IIDX and SDVX both have it set to

<component>
    <file>bm2dx.dll</file>
    <param>dummy</param>
</component>
<component><file>soundvoltex.dll</file><param>dummy</param></component>

Does nostalgia bug out if it's not completely empty?

If not, I think it's fine, as the goal here was the just not be required to pass in the additional file when not needed anymore.

In GitLab by @xyen on Dec 25, 2019, 10:19 Commented on [src/main/launcher/main.c line 251](https://github.com/djhackersdev/bemanitools/compare/634a3f5e7eeec0b3e166f592c6a1275ed55beeab..c24376b99cf056951becd25b160a3f1087c72cee#diff-5b44e1544fc6e2ee8377c919dd65f92dR251) weird, IIDX and SDVX both have it set to ```xml <component> <file>bm2dx.dll</file> <param>dummy</param> </component> ``` ```xml <component><file>soundvoltex.dll</file><param>dummy</param></component> ``` Does nostalgia bug out if it's not completely empty? If not, I think it's fine, as the goal here was the just not be required to pass in the additional file when not needed anymore.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#121