Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

sdvxhook2: Add sdvxhook2 - [merged] #113

New Issue
Closed
opened 2019-11-27 00:02:25 +03:00 by icex2 · 38 comments
icex2 commented 2019-11-27 00:02:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 26, 2019, 22:02

Merges sdvxhook2 -> master

Pretty self-explanatory.

In GitLab by @xyen on Nov 26, 2019, 22:02 _Merges sdvxhook2 -> master_ Pretty self-explanatory.
icex2 commented 2019-11-27 00:03:17 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @tudor on Nov 26, 2019, 22:03

Commented on dist/sdvx5/gamestart.bat line 16

sdvxhook2? or sdvxhook5?

In GitLab by @tudor on Nov 26, 2019, 22:03 Commented on [dist/sdvx5/gamestart.bat line 16](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..cf822851ede35234a02ced404fe19c7cdf7092bf#diff-d372fae359aa924ced9b34198bd72710R16) sdvxhook2? or sdvxhook5?
icex2 commented 2019-11-27 00:04:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 26, 2019, 22:04

Commented on dist/sdvx5/gamestart.bat line 16

changed this line in version 2 of the diff

In GitLab by @xyen on Nov 26, 2019, 22:04 Commented on [dist/sdvx5/gamestart.bat line 16](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..cf822851ede35234a02ced404fe19c7cdf7092bf#diff-d372fae359aa924ced9b34198bd72710R16) changed this line in [version 2 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1085&start_sha=cf822851ede35234a02ced404fe19c7cdf7092bf#1a5ac3e63ab5460cdbdb5887e8990d1204f37718_16_16)
icex2 commented 2019-11-27 00:04:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 26, 2019, 22:04

added 1 commit

  • e42de4fa - sdvxhoook2: typo in gamestart

Compare with previous version

In GitLab by @xyen on Nov 26, 2019, 22:04 added 1 commit <ul><li>e42de4fa - sdvxhoook2: typo in gamestart</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1085&start_sha=cf822851ede35234a02ced404fe19c7cdf7092bf)
icex2 commented 2019-11-27 00:04:37 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 26, 2019, 22:04

resolved all threads

In GitLab by @xyen on Nov 26, 2019, 22:04 resolved all threads
icex2 commented 2019-11-27 00:21:54 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Copy/paste leftover: IIDX ACIO bus

Nit: Copy/paste leftover: IIDX ACIO bus
icex2 commented 2019-11-27 00:28:47 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Include order: System includes with <...> before project/local includes with "..."

Include order: System includes with <...> before project/local includes with "..."
icex2 commented 2019-11-27 00:29:13 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Empty line before control block

Nit: Empty line before control block
icex2 commented 2019-11-27 00:30:29 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: leading underscore to function name?

Nit: leading underscore to function name?
icex2 commented 2019-11-27 00:31:41 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Style: Make variable names of struct lower-case

Style: Make variable names of struct lower-case
icex2 commented 2019-11-27 00:33:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Is this really a thing we need for sdvxhook2 as well? Hard to believe considering this was required with IIDX 16 initially.

Is this really a thing we need for sdvxhook2 as well? Hard to believe considering this was required with IIDX 16 initially.
icex2 commented 2019-11-27 00:34:46 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Missing newline after control block

Nit: Missing newline after control block
icex2 commented 2019-11-27 00:38:20 +03:00 (Migrated from github.com)
Copy Link
Copy Source

My previous d3d9 hook module refactoring for IIDX also changed the main interfaces to init and configure the module which made the whole module more streamlined imo.
Suggestions:

  • Introduce a configuration structure that takes parameters to configure the module instead of having multiple function calls (see iidxhook-util/d3d9.h)
  • Have one function to init a configuration with default values and one to apply one to the module.
My previous d3d9 hook module refactoring for IIDX also changed the main interfaces to init and configure the module which made the whole module more streamlined imo. Suggestions: - Introduce a configuration structure that takes parameters to configure the module instead of having multiple function calls (see iidxhook-util/d3d9.h) - Have one function to init a configuration with default values and one to apply one to the module.
icex2 commented 2019-11-27 00:39:41 +03:00 (Migrated from github.com)
Copy Link
Copy Source

"Disable BIO2 emulation and enable usage of real BIO2 hardware on COM4"

"Disable BIO2 emulation and enable usage of real BIO2 hardware **on COM4**"
icex2 commented 2019-11-27 00:45:43 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Some general notes:

  • Proper namespacing of functions in modules is sometimes missing, e.g. acio_XXX -> sdvxhook2_acio_XXX. I assume because these were copy-pasted from existing infrastructure and adapted to work with sdvxhook2 which is fine. For new code, we should stick to some guidelines to establish a consistent style over time.
  • Add a sdvxhook2.md readme file similar to iidxhookX.md readme files
  • Can you add tests for the various modules? Especially tests to verify the bio2 and acio modules are processing messages correctly would be good to ensure any changes/refactorings can be verified without having to boot the games.
Some general notes: - Proper namespacing of functions in modules is sometimes missing, e.g. acio_XXX -> sdvxhook2_acio_XXX. I assume because these were copy-pasted from existing infrastructure and adapted to work with sdvxhook2 which is fine. For new code, we should stick to some guidelines to establish a consistent style over time. - Add a sdvxhook2.md readme file similar to iidxhookX.md readme files - Can you add tests for the various modules? Especially tests to verify the bio2 and acio modules are processing messages correctly would be good to ensure any changes/refactorings can be verified without having to boot the games.
icex2 commented 2019-11-30 17:09:26 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:09

Commented on src/main/sdvxhook2/config-io.c line 29

This actually isn't the case, it enables usage of real BIO2 hardware on whatever the port that the BIO2 declares it self as. I just happened to pick COM4 as the default.

In GitLab by @xyen on Nov 30, 2019, 15:09 Commented on [src/main/sdvxhook2/config-io.c line 29](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..f69f0a8b467153efb76a67da8b27c4b863cc6164#diff-2872553b0e62c03f1e202c4c238e5fe9R29) This actually isn't the case, it enables usage of real BIO2 hardware on whatever the port that the BIO2 declares it self as. I just happened to pick COM4 as the default.
icex2 commented 2019-11-30 17:12:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:12

Commented on src/main/sdvxhook2/acio.c line 80

changed this line in version 3 of the diff

In GitLab by @xyen on Nov 30, 2019, 15:12 Commented on [src/main/sdvxhook2/acio.c line 80](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#diff-43cf661a7d47e05b9deb3d84212ab9dfR80) changed this line in [version 3 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1095&start_sha=e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#703bf4a3b449a44ac3a22dff31d9ec44c3c703b6_80_80)
icex2 commented 2019-11-30 17:12:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:12

Commented on src/main/sdvxhook2/bi2a.c line 165

changed this line in version 3 of the diff

In GitLab by @xyen on Nov 30, 2019, 15:12 Commented on [src/main/sdvxhook2/bi2a.c line 165](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#diff-746a3ce80a510b99a97dd57598191af8R165) changed this line in [version 3 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1095&start_sha=e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#fd9a41a6b813cdd3f986518dd082019d73dcac43_165_165)
icex2 commented 2019-11-30 17:12:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:12

Commented on src/main/sdvxhook2/bi2a.h line 49

changed this line in version 3 of the diff

In GitLab by @xyen on Nov 30, 2019, 15:12 Commented on [src/main/sdvxhook2/bi2a.h line 49](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#diff-9f5b0f72307afcd234907a7931260e64R49) changed this line in [version 3 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1095&start_sha=e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#235ef76b90f44c426c30e4d1fad10e504f2e7832_49_49)
icex2 commented 2019-11-30 17:12:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:12

Commented on src/main/sdvxhook2/config-gfx.c line 33

changed this line in version 3 of the diff

In GitLab by @xyen on Nov 30, 2019, 15:12 Commented on [src/main/sdvxhook2/config-gfx.c line 33](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#diff-48da6d5e179881d5f84157da6ec74d6fR33) changed this line in [version 3 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1095&start_sha=e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a#8aa5b09685f7bdf3306c252fe3b8b2e688cfa285_33_27)
icex2 commented 2019-11-30 17:12:22 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:12

added 1 commit

  • bcabc208 - sdvxhook: remove pci override for gfx hooks and general cleanup

Compare with previous version

In GitLab by @xyen on Nov 30, 2019, 15:12 added 1 commit <ul><li>bcabc208 - sdvxhook: remove pci override for gfx hooks and general cleanup</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1095&start_sha=e42de4fa64f8a4fd3eaab5f80ac5fd28d87d647a)
icex2 commented 2019-11-30 17:15:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:15

Commented on src/main/sdvxhook2/d3d9.h line 10

I'm going to factor out this code into d3d9exhook as some other games require this as well, anything that's new enough to require d3d9ex likely won't need any game specific hacks which is why I'd rather have the graphics hooks be shared across games.

In GitLab by @xyen on Nov 30, 2019, 15:15 Commented on [src/main/sdvxhook2/d3d9.h line 10](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..bcabc2085ad7424414a784b1a6ce2cd7955b633d#diff-dd0c870caea58a55c6bd5c8699ffe2daR10) I'm going to factor out this code into d3d9exhook as some other games require this as well, anything that's new enough to require d3d9ex likely won't need any game specific hacks which is why I'd rather have the graphics hooks be shared across games.
icex2 commented 2019-11-30 17:15:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 15:15

resolved all threads

In GitLab by @xyen on Nov 30, 2019, 15:15 resolved all threads
icex2 commented 2019-11-30 18:00:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 16:00

Commented on src/main/sdvxhook2/d3d9.c line 181

changed this line in version 4 of the diff

In GitLab by @xyen on Nov 30, 2019, 16:00 Commented on [src/main/sdvxhook2/d3d9.c line 181](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..bcabc2085ad7424414a784b1a6ce2cd7955b633d#diff-829e3b5f1ef14eef84c91208013efd1eR181) changed this line in [version 4 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1096&start_sha=bcabc2085ad7424414a784b1a6ce2cd7955b633d#a1dcf5787f100714d28d910af27de6127293dd9c_181_0)
icex2 commented 2019-11-30 18:00:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 16:00

Commented on src/main/sdvxhook2/d3d9.h line 10

changed this line in version 4 of the diff

In GitLab by @xyen on Nov 30, 2019, 16:00 Commented on [src/main/sdvxhook2/d3d9.h line 10](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..bcabc2085ad7424414a784b1a6ce2cd7955b633d#diff-dd0c870caea58a55c6bd5c8699ffe2daR10) changed this line in [version 4 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1096&start_sha=bcabc2085ad7424414a784b1a6ce2cd7955b633d#fb18c92b9cc1e8be4b73caf5c06fc0c5dd6e62bb_10_0)
icex2 commented 2019-11-30 18:00:39 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 16:00

added 1 commit

  • e2b2fcb5 - d3d9exhook: refactor d3d9ex hook from sdvxhook2 to shared library

Compare with previous version

In GitLab by @xyen on Nov 30, 2019, 16:00 added 1 commit <ul><li>e2b2fcb5 - d3d9exhook: refactor d3d9ex hook from sdvxhook2 to shared library</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1096&start_sha=bcabc2085ad7424414a784b1a6ce2cd7955b633d)
icex2 commented 2019-11-30 18:05:24 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Nov 30, 2019, 16:05

added 1 commit

  • a840e452 - d3d9exhook: refactor d3d9ex hook from sdvxhook2 to shared library

Compare with previous version

In GitLab by @xyen on Nov 30, 2019, 16:05 added 1 commit <ul><li>a840e452 - d3d9exhook: refactor d3d9ex hook from sdvxhook2 to shared library</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1097&start_sha=e2b2fcb5ed56002dedde902877123e243ff6690e)
icex2 commented 2019-11-30 22:48:57 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Documentation

Nit: Documentation
icex2 commented 2019-11-30 22:49:01 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Documentation

Nit: Documentation
icex2 commented 2019-11-30 22:49:45 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Nit: Documentation

Nit: Documentation
icex2 commented 2019-11-30 22:50:38 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Is that a TODO you missed? And is that even possible here?

Is that a TODO you missed? And is that even possible here?
icex2 commented 2019-11-30 22:51:32 +03:00 (Migrated from github.com)
Copy Link
Copy Source

What's the reason for still keeping this method hooked?

What's the reason for still keeping this method hooked?
icex2 commented 2019-11-30 22:53:36 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Moving the d3d9ex hooking code to a separate (static) module is a good idea, well done.

Moving the d3d9ex hooking code to a separate (static) module is a good idea, well done.
icex2 commented 2019-12-01 05:42:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Dec 1, 2019, 03:42

Commented on src/main/d3d9exhook/d3d9ex.c line 98

In the future, we may wanna override the monitor id still, or fake additional monitors.

In GitLab by @xyen on Dec 1, 2019, 03:42 Commented on [src/main/d3d9exhook/d3d9ex.c line 98](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..f69f0a8b467153efb76a67da8b27c4b863cc6164#diff-88be4261cef25befc4653e41ac224407R98) In the future, we may wanna override the monitor id still, or fake additional monitors.
icex2 commented 2019-12-01 05:46:03 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Dec 1, 2019, 03:46

resolved all threads

In GitLab by @xyen on Dec 1, 2019, 03:46 resolved all threads
icex2 commented 2019-12-01 05:46:40 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Dec 1, 2019, 03:46

Commented on src/main/d3d9exhook/d3d9ex.c line 247

changed this line in version 6 of the diff

In GitLab by @xyen on Dec 1, 2019, 03:46 Commented on [src/main/d3d9exhook/d3d9ex.c line 247](https://github.com/djhackersdev/bemanitools/compare/e45b0927757b62ec0ce107517033b451e13406b0..a840e452dd9ec4d3299db55a6e343c243b5a00dd#diff-88be4261cef25befc4653e41ac224407R247) changed this line in [version 6 of the diff](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1098&start_sha=a840e452dd9ec4d3299db55a6e343c243b5a00dd#635ef12b21ec4a077c76251b15c5580dd5d42f19_247_247)
icex2 commented 2019-12-01 05:46:41 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Dec 1, 2019, 03:46

added 1 commit

  • f69f0a8b - sdvxhook2: add some minor documentation to config-gfx.h

Compare with previous version

In GitLab by @xyen on Dec 1, 2019, 03:46 added 1 commit <ul><li>f69f0a8b - sdvxhook2: add some minor documentation to config-gfx.h</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/12/diffs?diff_id=1098&start_sha=a840e452dd9ec4d3299db55a6e343c243b5a00dd)
icex2 commented 2019-12-01 12:20:41 +03:00 (Migrated from github.com)
Copy Link
Copy Source

LGTM now. Feel free to merge.

LGTM now. Feel free to merge.
icex2 commented 2019-12-01 16:05:53 +03:00 (Migrated from github.com)
Copy Link
Copy Source

In GitLab by @xyen on Dec 1, 2019, 14:05

merged

In GitLab by @xyen on Dec 1, 2019, 14:05 merged
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#113