Max/djhackersdev_bemanitools
1
0
Fork 0
Code Issues 72 Pull Requests 15 Actions Packages Projects Releases 20 Wiki Activity

Add code formatting and testing to build pipeline. - [merged] #107

New Issue
Closed
opened 2019-10-20 00:14:28 +03:00 by icex2 · 8 comments
icex2 commented 2019-10-20 00:14:28 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Merges clang-format-build-pipeline -> master

Summary

Self explanatory title.

Description

Adds a few makefile targets to format, test and release build.

Related Issue

#3

How Has This Been Tested?

Development environment in shell.

_Merges clang-format-build-pipeline -> master_ ## Summary <!--- Provide a general summary of your changes in the Title above --> Self explanatory title. ## Description <!--- Describe your changes in detail --> Adds a few makefile targets to format, test and release build. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #3 ## How Has This Been Tested? Development environment in shell.
icex2 commented 2019-10-20 00:48:02 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 2 commits

  • 16c7cc4a - Some clang-format tweaks to optimize code style
  • e6330fa4 - Apply clang-format code style to all source files

Compare with previous version

added 2 commits <ul><li>16c7cc4a - Some clang-format tweaks to optimize code style</li><li>e6330fa4 - Apply clang-format code style to all source files</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/6/diffs?diff_id=1055&start_sha=6741a1f2fd6d6efc597ff69641aa6be3212b8727)
icex2 commented 2019-10-20 01:29:06 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 2 commits

  • 67ffd87f - Some clang-format tweaks to optimize code style
  • a0b2c81e - Apply clang-format code style to all source files

Compare with previous version

added 2 commits <ul><li>67ffd87f - Some clang-format tweaks to optimize code style</li><li>a0b2c81e - Apply clang-format code style to all source files</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/6/diffs?diff_id=1056&start_sha=e6330fa4cdc9c258ed7e3823d5e3df6a952c6495)
icex2 commented 2019-10-20 01:48:30 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 2 commits

  • 99e2764d - Some clang-format tweaks to optimize code style
  • 069dd83b - Apply clang-format code style to all source files

Compare with previous version

added 2 commits <ul><li>99e2764d - Some clang-format tweaks to optimize code style</li><li>069dd83b - Apply clang-format code style to all source files</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/6/diffs?diff_id=1057&start_sha=a0b2c81ef673eaac06aab0e2d2a385a81279bf89)
icex2 commented 2019-10-20 01:50:45 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 2 commits

  • c600e1a4 - Some clang-format tweaks to optimize code style
  • c3bc8782 - Apply clang-format code style to all source files

Compare with previous version

added 2 commits <ul><li>c600e1a4 - Some clang-format tweaks to optimize code style</li><li>c3bc8782 - Apply clang-format code style to all source files</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/6/diffs?diff_id=1058&start_sha=069dd83bbb34b919359fdbbfae1a6c455ab117bd)
icex2 commented 2019-10-22 22:05:35 +03:00 (Migrated from github.com)
Copy Link
Copy Source

added 1 commit

  • b6e58811 - Various import fixes caused by clang-format

Compare with previous version

added 1 commit <ul><li>b6e58811 - Various import fixes caused by clang-format</li></ul> [Compare with previous version](/djhackers/bemanitools/merge_requests/6/diffs?diff_id=1059&start_sha=c3bc8782f4a344bc24e6951fbbc5ed56673c65a9)
icex2 commented 2019-10-22 22:06:21 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Everything's fixed and compiles, though not tested, yet. Testing follows soon.

Everything's fixed and compiles, though not tested, yet. Testing follows soon.
icex2 commented 2019-10-23 21:19:56 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Successfully tested IIDX 9, 13, 14, 24 and 26 by booting them up and starting a song.

Successfully tested IIDX 9, 13, 14, 24 and 26 by booting them up and starting a song.
icex2 commented 2019-10-23 21:22:05 +03:00 (Migrated from github.com)
Copy Link
Copy Source

merged

merged
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acio
bio2
bst
bug
Something isn't working
 ddr
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 ezusb
feature
gitlab merge request
good first issue
Good for newcomers
 has attachment
help wanted
Extra attention is needed
 high priority
iidx
invalid
This doesn't seem right
 jb
low priority
museca
popn
question
Further information is requested
 sdvx
tech debt
wontfix
This will not be worked on
No labels gitlab merge request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#107