Minor texture align issue with IIDX18/19 diagonal texture fix. #100

Open
opened 2022-09-18 08:59:13 +03:00 by icex2 · 8 comments
icex2 commented 2022-09-18 08:59:13 +03:00 (Migrated from github.com)

In GitLab by @Radio on Sep 18, 2022, 07:59

Summary

Slight texture misalignment happens to various textures resulting in top or bottom parts being slightly cut-off.

Expected behavior

Textures should be properly aligned without cut-off parts.

Current behavior

Some textures are being sliced horizontally on the top or bottom, or perhaps they're misaligned?

Detailed Description

Example from my recent stream, you can clearly see it on the top of the screen on mode select: https://youtu.be/3VPpASrQY10?t=434

Steps to reproduce

  1. Enable diagonal texture fix.

Possible solution

Context (Environment)

Bemanitools version(s) affected

  • 5.42

Game(s) and version(s) affected

  • IIDX 18
  • IIDX 19

Log output

See attachment.

Configuration files

See attachment.

Diagonal texture fix enabled.

Command line arguments

APIs used

OS version

Windows 11

Hardware specs

  • CPU:
  • RAM:
  • GPU: GTX 660, r7 240
  • Controllers/IO:
In GitLab by @Radio on Sep 18, 2022, 07:59 ## Summary <!--- Provide a general summary of the issue in the Title above --> Slight texture misalignment happens to various textures resulting in top or bottom parts being slightly cut-off. ## Expected behavior <!--- Tell us what should happen --> Textures should be properly aligned without cut-off parts. ## Current behavior <!--- Tell us what happens instead of the expected behavior --> Some textures are being sliced horizontally on the top or bottom, or perhaps they're misaligned? ## Detailed Description <!--- Provide a detailed description of the issue. Include links to screenshots or videos if necessary --> Example from my recent stream, you can clearly see it on the top of the screen on mode select: https://youtu.be/3VPpASrQY10?t=434 ## Steps to reproduce <!-- Try running the game with a default configuration as well. If that also causes issues, please point that out here in the report. This might speed up the debugging process.--> <!--- Provide a detailed step by step description how to reproduce this issue --> 1. Enable diagonal texture fix. ## Possible solution <!--- Not obligatory, but suggest a fix/reason for the bug, --> ## Context (Environment) ### Bemanitools version(s) affected * <!--- Add one or multiple versions as a bullet list --> * 5.42 ### Game(s) and version(s) affected * <!--- Add one or multiple game versions as a bullet list --> * IIDX 18 * IIDX 19 ### Log output See attachment. <!--- Provide FULL log output, e.g. inject.log or launcher.log. Please do not guess which things are relevant or not. Without knowing, you might leave out things that are relevant for the developers. You have to enable log output explicitly if not done already. For inject.exe and launcher.exe, add `-Y logfile.log` to the command line args to output to a file, e.g. `gamestart.bat -Y logfile.log`. !!!!!! REMOVE ANY SENSITIVE DATA LIKE PCBIDS OR DEVICE NAMES BY REPLACING IT THEM WITH [REDACTED] BEFORE UPLOADING/POSTING ANY LOG DATA!!! Use the search and replace feature of any kind of text editor. !!!!!! --> ### Configuration files See attachment. <!--- Provide any configuration files that you used, e.g. iidxhook-XX.conf. This file is located in the same directory as launcher.exe or inject.exe. !!!!!! REMOVE ANY SENSITIVE DATA LIKE PCBIDS OR DEVICE NAMES BY REPLACING IT THEM WITH [REDACTED] BEFORE UPLOADING/POSTING ANY LOG DATA!!! Use the search and replace feature of any kind of text editor. !!!!!! --> Diagonal texture fix enabled. ### Command line arguments <!--- Provide how you run the game from the command line, e.g. which gamestart.bat you used and any additional arguments that you provided to it. Also provide the contents of the gamestart.bat you used if you altered it. --> ### APIs used * <!--- List all APIs you used as a bullet list, e.g. iidxio-keyboard, eamio-keyboard --> ### OS version <!--- Provide the version of Windows you used with whatever update/build identifier --> Windows 11 ### Hardware specs * CPU: <!--- Insert, e.g. Core i7 2600k 3.20ghz --> * RAM: <!--- Insert, e.g. 16 GB --> * GPU: <!--- Insert, e.g. Nvidia GeForce GTX 970, 4GB --> GTX 660, r7 240 * Controllers/IO: <!--- Insert, e.g. DJ Dao RE over USB -->
icex2 commented 2022-09-18 19:48:20 +03:00 (Migrated from github.com)

Can you run the game in window mode and check if the top/bottom of the rendered picture in the window is also showing that? Screenshot for evidence appreciated.

Can you run the game in window mode and check if the top/bottom of the rendered picture in the window is also showing that? Screenshot for evidence appreciated.
icex2 commented 2022-09-18 20:02:42 +03:00 (Migrated from github.com)

In GitLab by @Radio on Sep 18, 2022, 19:02

Actually, it seems like you can't see the one on mode select when running windowed without any scaling.

image

But I've found another example, take a look at the stage difficulties here, you can see STAGE 5 being cut-off from the bottom. Also looks like the PASELI text is missing its black outline on the bottom.

image

There's also this that has some values exhibiting the diagonal texture bug, you can see it on the DJ name for example. You can also easily see the SP league level is fine but the DP one is bugged.

image

Edit: I forgot to mention, the videos also have the diagonal seem across them. Sometimes it's hard to notice but it's there.

In GitLab by @Radio on Sep 18, 2022, 19:02 Actually, it seems like you can't see the one on mode select when running windowed without any scaling. ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/6edf5a0a1d967bb038d4fad2d878174b/image.png) But I've found another example, take a look at the stage difficulties here, you can see STAGE 5 being cut-off from the bottom. Also looks like the PASELI text is missing its black outline on the bottom. ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/61449c8f9e6cc0439085e3b740d5fe93/image.png) There's also this that has some values exhibiting the diagonal texture bug, you can see it on the DJ name for example. You can also easily see the SP league level is fine but the DP one is bugged. ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/d064aaeb801422c3cc8b779437da3bf4/image.png) Edit: I forgot to mention, the videos also have the diagonal seem across them. Sometimes it's hard to notice but it's there.
icex2 commented 2022-09-18 20:48:50 +03:00 (Migrated from github.com)

That sounds like either the "diagonal texture fix" is not turned on or doesn't work as expected. If you got it turned on, can you turn off and provide screenshots of the screens above for comparison?

That sounds like either the "diagonal texture fix" is not turned on or doesn't work as expected. If you got it turned on, can you turn off and provide screenshots of the screens above for comparison?
icex2 commented 2022-09-18 20:55:27 +03:00 (Migrated from github.com)

In GitLab by @Radio on Sep 18, 2022, 19:55

Wow I'm sorry for being dumb, those screenshots were indeed without the fix turned on. But now I can actually provide the evidence for mode select misalignment. It should serve as good comparison if nothing else.

image
image
image
image

In GitLab by @Radio on Sep 18, 2022, 19:55 Wow I'm sorry for being dumb, those screenshots were indeed without the fix turned on. But now I can actually provide the evidence for mode select misalignment. It should serve as good comparison if nothing else. ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/12859e4ee7052bebc310cea4072a4d26/image.png) ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/ae77a784ce37aee48fe3c0709e800fc5/image.png) ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/9d525264cd2cf216f832c158921d5e2c/image.png) ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/97e586c0834bc545b10d5fd2a9984340/image.png)
icex2 commented 2022-09-18 21:36:58 +03:00 (Migrated from github.com)

Thanks for these. Seems this is not related to the "texture seam fix" at all then. Since it's an "odd gfx" bug again, I guess it's related to some code that worked fine on those x1300 radeon cards (IIRC) just fine. By accident, you don't happen to have another PC with any ATI card?

Thanks for these. Seems this is not related to the "texture seam fix" at all then. Since it's an "odd gfx" bug again, I guess it's related to some code that worked fine on those x1300 radeon cards (IIRC) just fine. By accident, you don't happen to have another PC with any ATI card?
icex2 commented 2022-09-19 08:14:21 +03:00 (Migrated from github.com)

In GitLab by @Radio on Sep 19, 2022, 07:14

I actually have the card that can run the games correctly lying around somewhere, I can hook it up and provide screenshots if you really want them. But I've got these that look perfect running on toastertools, hopefully they'll be useful:
image
image

In GitLab by @Radio on Sep 19, 2022, 07:14 I actually have the card that can run the games correctly lying around somewhere, I can hook it up and provide screenshots if you really want them. But I've got these that look perfect running on toastertools, hopefully they'll be useful: ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/301eeed19b1fb2534f6f988890789ec7/image.png) ![image](https://dev.s-ul.net/djhackers/bemanitools/uploads/1d1714b2c159494261e39106dc45fc93/image.png)
icex2 commented 2022-09-19 19:24:56 +03:00 (Migrated from github.com)

That's definintely useful information. So toastertools fixed something else that bemanitools doesn't have, yet. Thanks for the additional references.

That's definintely useful information. So toastertools fixed something else that bemanitools doesn't have, yet. Thanks for the additional references.
JeffPaine4890 commented 2023-03-29 12:31:21 +03:00 (Migrated from github.com)

Possibly related, Chinese Resort Anthem also has misaligned note beams that I don't get on Japanese Resort Anthem
ra-cn

Possibly related, Chinese Resort Anthem also has misaligned note beams that I don't get on Japanese Resort Anthem ![ra-cn](https://user-images.githubusercontent.com/110370440/228491315-611e31f4-a98b-4701-9699-bad7c0cbd6d2.png)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/djhackersdev_bemanitools#100