From f4b6810d67af276683eea04910c6a26d66fdc18b Mon Sep 17 00:00:00 2001 From: retroNUC <71151161+retroNUC@users.noreply.github.com> Date: Tue, 16 Jan 2024 02:43:46 +0000 Subject: [PATCH] Update achievements.js (#6) Fix issue where achievements page wouldn't render when using older game data than achievements.json expects (failure to lookup akaname for aptitle reward) --- sdvx@asphyxia/webui/asset/js/achievements.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sdvx@asphyxia/webui/asset/js/achievements.js b/sdvx@asphyxia/webui/asset/js/achievements.js index 63ccc44..287f02b 100644 --- a/sdvx@asphyxia/webui/asset/js/achievements.js +++ b/sdvx@asphyxia/webui/asset/js/achievements.js @@ -31,7 +31,12 @@ async function populateAch(listType) { if(ach['rtype'] === 'pcb') { reward = ach['rid'] + " PCB" } else if(ach['rtype'] === 'aptitle') { - reward = "Appeal Title \"" + aptitlelist.find(e => parseInt(e['value']) === ach['rid'])['name'] + "\"" + let aptitle = aptitlelist.find(e => parseInt(e['value']) === ach['rid']) + if (aptitle !== undefined) { + reward = "Appeal Title \"" + aptitle['name'] + "\"" + } else { + reward = "Unknown Appeal Title" + } } } else { reward = '-----'