isolabel should be sanitized #34

Closed
opened 2022-08-26 14:43:55 +03:00 by b0ch3nski · 5 comments
b0ch3nski commented 2022-08-26 14:43:55 +03:00 (Migrated from github.com)

isolabel can contain chars that mkfs.vfat cannot accept

https://github.com/ValdikSS/windows2usb/blob/9f855faabd9f33998b3c773927311510877f15a6/windows2usb#L252

mkfs.vfat: Labels with characters *?.,;:/\|+=<>[]" are not allowed
`isolabel` can contain chars that `mkfs.vfat` cannot accept https://github.com/ValdikSS/windows2usb/blob/9f855faabd9f33998b3c773927311510877f15a6/windows2usb#L252 ``` mkfs.vfat: Labels with characters *?.,;:/\|+=<>[]" are not allowed ```
ValdikSS commented 2022-09-05 00:38:09 +03:00 (Migrated from github.com)

I assume you have a custom ISO file. Custom ISO files are generally not supported as they may contain many modifications as Windows installer system is pretty flexible, which are not handled by windows2usb.

I assume you have a custom ISO file. Custom ISO files are generally not supported as they may contain many modifications as Windows installer system is pretty flexible, which are not handled by windows2usb.
b0ch3nski commented 2022-09-05 11:39:06 +03:00 (Migrated from github.com)

Agreed, but replacing the not allowed chars would be pretty much simple and protect from at least this kind of issue ;)

Agreed, but replacing the not allowed chars would be pretty much simple and protect from at least this kind of issue ;)
Manouchehri commented 2022-09-14 23:57:29 +03:00 (Migrated from github.com)

@b0ch3nski What did you end up using to create the USB?

EDIT: Ventoy worked for me.

@b0ch3nski What did you end up using to create the USB? EDIT: Ventoy worked for me.
b0ch3nski commented 2022-09-20 18:07:41 +03:00 (Migrated from github.com)

@b0ch3nski What did you end up using to create the USB?

@Manouchehri Monkey-patch the code - remove these lines:

    isolabel="$(get_iso_name "$isopath")"
    if [ $? -ne 0 ]
    then
        isolabel=""
    fi

It will create the empty ISO label which will avoid the FAT32 limitations.

> @b0ch3nski What did you end up using to create the USB? @Manouchehri Monkey-patch the code - remove these lines: ``` isolabel="$(get_iso_name "$isopath")" if [ $? -ne 0 ] then isolabel="" fi ``` It will create the empty ISO label which will avoid the FAT32 limitations.
ValdikSS commented 2022-12-07 02:17:15 +03:00 (Migrated from github.com)

Fixed in 0.2.2

Fixed in 0.2.2
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/ValdikSS_windows2usb#34