From 9c3428cbbf1be6cb3a6dd97fcba72ca86fdb70e6 Mon Sep 17 00:00:00 2001
From: Loren Eteval <loren.eteval@proton.me>
Date: Fri, 10 May 2024 19:16:59 +0800
Subject: [PATCH] Fix guiEditor open() bug

Signed-off-by: Loren Eteval <loren.eteval@proton.me>
---
 Furious/Widget/UserServersQTableWidget.py | 54 +++++++++++++++--------
 1 file changed, 35 insertions(+), 19 deletions(-)

diff --git a/Furious/Widget/UserServersQTableWidget.py b/Furious/Widget/UserServersQTableWidget.py
index dd01c28..3bf3373 100644
--- a/Furious/Widget/UserServersQTableWidget.py
+++ b/Furious/Widget/UserServersQTableWidget.py
@@ -937,27 +937,43 @@ class UserServersQTableWidget(QTranslatable, AppQTableWidget):
 
             logger.error(f'error while converting factory to input: {ex}')
 
-        def handleAccepted():
-            modified = guiEditor.inputToFactory(factory)
-
-            if modified:
-                self.flushRow(index, factory)
-
-                if index == AS_UserActivatedItemIndex():
-                    try:
-                        if APP().isSystemTrayConnected():
-                            mbox = NewChangesNextTimeMBox()
-
-                            # Show the MessageBox asynchronously
-                            mbox.open()
-                    except Exception:
-                        # Any non-exit exceptions
-
-                        pass
-
-        guiEditor.connectAccepted(handleAccepted)
+        guiEditor.accepted.connect(
+            functools.partial(
+                self.handleGuiEditorAccepted,
+                guiEditor,
+                index,
+                factory,
+            )
+        )
         guiEditor.open()
 
+    def handleGuiEditorAccepted(
+        self,
+        editor: GuiEditorWidgetQDialog,
+        index: int,
+        factory: ConfigurationFactory,
+    ):
+        logger.debug(f'guiEditor accepted with index {index}')
+
+        modified = editor.inputToFactory(factory)
+
+        if modified:
+            self.flushRow(index, factory)
+
+            if index == AS_UserActivatedItemIndex():
+                try:
+                    if APP().isSystemTrayConnected():
+                        mbox = NewChangesNextTimeMBox()
+
+                        # Show the MessageBox asynchronously
+                        mbox.open()
+                except Exception:
+                    # Any non-exit exceptions
+
+                    pass
+
+        editor.accepted.disconnect()
+
     @QtCore.Slot(QtCore.QPoint)
     def handleCustomContextMenuRequested(self, point):
         self.contextMenu.exec(self.mapToGlobal(point))