Max/Goatgarien_BAKKA-Editor
1
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 13 Wiki Activity

Minor playback changes #9

Merged
Farex-GH merged 6 commits from feat/playback into C#-master 2022-09-11 11:10:54 +03:00
Conversation 0 Commits 6 Files Changed 2
+284 -281
Farex-GH commented 2022-09-11 11:04:25 +03:00 (Migrated from github.com)
Copy Link
Copy Source

Hi,

This PR fixes a null pointer dereference that could happen when the user would seek in the song playback bar before they have a song selected.
It also adds volume control and smoother seeking to bars in the playback area.

I haven't written any C# before, so feel free to let me know if the naming or style conventions differ from C# conventions.

Hi, This PR fixes a null pointer dereference that could happen when the user would seek in the song playback bar before they have a song selected. It also adds volume control and smoother seeking to bars in the playback area. I haven't written any C# before, so feel free to let me know if the naming or style conventions differ from C# conventions.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Max
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Max/Goatgarien_BAKKA-Editor#9